-
Notifications
You must be signed in to change notification settings - Fork 0
fix(nvim): resolve healthcheck warnings and add missing formatter tools #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
19a2fe4
ff6f39a
4db1900
03d3479
b1819df
0402b47
7342b52
b8ef088
bb2524d
8cd290f
b25bf3e
fe1fcc5
4419590
0259c2b
887ba68
6411fa3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| docker | ||
| docker-compose | ||
| dockerfile-language-server | ||
| ]; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| { pkgs, ... }: | ||
| { pkgs, lib, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| go | ||
| (lib.lowPrio gotools) | ||
| gopls | ||
| ]; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { pkgs, ... }: | ||
| { | ||
| home.packages = with pkgs; [ | ||
| k9s | ||
| kind | ||
| kubeconform | ||
| kubectl | ||
| kubectx | ||
| kubernetes-helm | ||
| kustomize | ||
| ]; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,5 +3,6 @@ | |
| home.packages = with pkgs; [ | ||
| lua | ||
| lua-language-server | ||
| stylua | ||
| ]; | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -73,7 +73,7 @@ cmp.setup.cmdline(":", { | |||||
| -- GitHub Copilot helper with inline suggestions disabled by default. | ||||||
| -- From: https://github.com/zbirenbaum/copilot.lua | ||||||
| require("copilot").setup({ | ||||||
| suggestion = { enabled = false }, | ||||||
| suggestion = { enabled = true }, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Keep copilot.lua inline suggestions disabled when using copilot-cmp; enabling them can interfere with cmp completions. Prompt for AI agents
Suggested change
|
||||||
| panel = { enabled = false }, | ||||||
| }) | ||||||
|
Comment on lines
73
to
78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: The copilot-cmp README recommends disabling the suggestion module in copilot.lua when using copilot-cmp. Specifically, set suggestion.enabled = false (along with panel.enabled = false) in the copilot.lua setup to prevent interference with completions appearing properly in the nvim-cmp menu provided by copilot-cmp. Citations:
🏁 Script executed: # Check if the file exists and examine lines 73-78
if [ -f "home-manager/programs/neovim/lua/config/completion.lua" ]; then
echo "=== completion.lua lines 70-80 ==="
sed -n '70,80p' "home-manager/programs/neovim/lua/config/completion.lua"
else
find . -name "completion.lua" -type f | head -5
fiRepository: shunkakinoki/dotfiles Length of output: 377 🏁 Script executed: # Check the test file for assertion about suggestion.enabled
if [ -f "home-manager/programs/neovim/tests/completion_spec.lua" ]; then
echo "=== completion_spec.lua lines 135-145 ==="
sed -n '135,145p' "home-manager/programs/neovim/tests/completion_spec.lua"
else
find . -name "completion_spec.lua" -type f | head -5
fiRepository: shunkakinoki/dotfiles Length of output: 447 🏁 Script executed: # Check for copilot-cmp configuration at lines 6 and 39 in completion.lua
if [ -f "home-manager/programs/neovim/lua/config/completion.lua" ]; then
echo "=== completion.lua lines 1-50 (to find copilot-cmp usage) ==="
sed -n '1,50p' "home-manager/programs/neovim/lua/config/completion.lua"
fiRepository: shunkakinoki/dotfiles Length of output: 1640 Stale comment, failing test, and configuration conflicts with copilot-cmp upstream guidance. Three issues with
🔧 Proposed fix-- GitHub Copilot helper with inline suggestions disabled by default.
+-- GitHub Copilot helper configured for nvim-cmp.
-- From: https://github.com/zbirenbaum/copilot.lua
require("copilot").setup({
- suggestion = { enabled = true },
+ suggestion = { enabled = false },
panel = { enabled = false },
})Ensure 🤖 Prompt for AI Agents |
||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the generated settings write atomic and non-interactive.
mktempdefaults outside~/.claude, somvmay degrade to copy+unlink across filesystems. Also usemv -fand clean up the temp file onjqfailure.Proposed fix
As per coding guidelines,
**/*.{sh,bash}: Always use non-interactive flags with file operations (cp -f,mv -f,rm -f,rm -rf,cp -rf) to avoid hanging on confirmation prompts.📝 Committable suggestion
🤖 Prompt for AI Agents