Opensessions - #1469
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughMultiple configuration files were updated: AMP endpoint switched to production, AMP integration commented out in CLI proxy templates, factory custom models removed, Ghostty keybindings added, TPM plugin and tmux added, vllm restricted to x86_64-linux, and Homebrew brews/casks adjusted. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRAdd OpenSessions support via a tmux plugin and Ghostty keybinds to streamline session navigation. Also cleans up AMP/config templates and adjusts package installs for stability. What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates configuration settings for AMP, the CLI proxy, and the factory model list, while adding new keybindings to Ghostty and the opensessions plugin to tmux. It also restricts the vllm package to x86_64-linux and updates Homebrew package lists. Feedback was provided regarding the non-idiomatic hardcoding of the TPM path in a Nix environment, the potential redundancy of managing tmux via Homebrew when it is already handled by Home Manager, and the miscategorization of CLI tools like claude-code and codex as casks instead of formulas.
| set -g @plugin 'Ataraxy-Labs/opensessions' | ||
|
|
||
| # Initialize TPM (keep at bottom) | ||
| run-shell ~/.tmux/plugins/tpm/tpm |
There was a problem hiding this comment.
Hardcoding the path to TPM (~/.tmux/plugins/tpm/tpm) is not idiomatic in a Nix-managed environment. This creates a non-hermetic dependency on external state that may not exist if TPM hasn't been manually cloned. In a Home Manager setup, it is recommended to manage tmux plugins using the programs.tmux.plugins option, which handles installation and initialization automatically.
| "sheldon" | ||
| "sshpass" | ||
| "temporal" | ||
| "tmux" |
There was a problem hiding this comment.
Adding tmux to the Homebrew brews list may be redundant if it is already managed via Home Manager (as indicated by the presence of home-manager/programs/tmux/tmux.conf). Managing core utilities through Nix is generally preferred in this setup to ensure consistency and avoid potential path conflicts between Homebrew and Nix-installed binaries.
| "chatgpt" | ||
| "cmux" | ||
| "claude-code@latest" | ||
| "claude-code" |
There was a problem hiding this comment.
claude-code is a CLI tool and should likely be listed under brews rather than casks. Casks are typically reserved for GUI applications. If this is a CLI tool distributed via a tap, moving it to the brews section will ensure it is installed correctly as a formula.
| "claude" | ||
| "codex-app" | ||
| "codex@latest" | ||
| "codex" |
There was a problem hiding this comment.
codex appears to be a CLI tool and should likely be moved to the brews list. The GUI version of the application is already correctly categorized as codex-app in the casks list.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
config/cliproxyapi/config.tpl.yaml (1)
41-52: Consider collapsing this fully-disabled AMP block to a short note.Since AMP is intentionally off here, maintaining detailed commented mappings adds noise and drift risk.
✂️ Optional cleanup
# AMP integration -# ampcode: - # upstream-url: "https://ampcode.com" - # upstream-api-key: "__AMP_UPSTREAM_API_KEY__" - # restrict-management-to-localhost: false - # Map non-prefixed model names to antigravity provider's gemini-prefixed models - # model-mappings: - # - from: "claude-opus-4-5-thinking" - # to: "gemini-claude-opus-4-5-thinking" - # - from: "claude-sonnet-4-6" - # to: "gemini-claude-sonnet-4-6" - # - from: "claude-sonnet-4-6-thinking" - # to: "gemini-claude-sonnet-4-6-thinking" +# AMP integration is intentionally disabled in this template. +# Re-enable by restoring ampcode upstream settings and model mappings.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@config/cliproxyapi/config.tpl.yaml` around lines 41 - 52, The commented-out AMP configuration block (ampcode and its keys like upstream-url, upstream-api-key, restrict-management-to-localhost, and model-mappings) is verbose while disabled; replace the large commented section with a short single-line note indicating AMP is disabled and mentioning where to restore full config (e.g., "AMP disabled — uncomment ampcode block to enable upstream-url, upstream-api-key, model-mappings for model name mappings"), removing the detailed commented model-mappings entries to reduce noise and drift.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@config/cliproxyapi/config.tpl.yaml`:
- Around line 41-52: The commented-out AMP configuration block (ampcode and its
keys like upstream-url, upstream-api-key, restrict-management-to-localhost, and
model-mappings) is verbose while disabled; replace the large commented section
with a short single-line note indicating AMP is disabled and mentioning where to
restore full config (e.g., "AMP disabled — uncomment ampcode block to enable
upstream-url, upstream-api-key, model-mappings for model name mappings"),
removing the detailed commented model-mappings entries to reduce noise and
drift.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9062781c-268b-46d5-83db-beec9160f6c6
📒 Files selected for processing (8)
config/amp/settings.jsonconfig/cliproxyapi/config.template.yamlconfig/cliproxyapi/config.tpl.yamlconfig/factory/config.jsonconfig/ghostty/confighome-manager/packages/default.nixhome-manager/programs/tmux/tmux.confnix-darwin/config/homebrew.nix
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="home-manager/programs/tmux/tmux.conf">
<violation number="1" location="home-manager/programs/tmux/tmux.conf:177">
P2: This hardcoded TPM bootstrap path is not provisioned by the repository's Home Manager tmux setup, so tmux will try to source a missing script on reload/startup.</violation>
</file>
<file name="config/amp/settings.json">
<violation number="1" location="config/amp/settings.json:2">
P2: Keep AMP pointed at the local proxy. This change bypasses the repository’s `localhost:8317` integration and sends requests straight to the upstream service instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| set -g @plugin 'Ataraxy-Labs/opensessions' | ||
|
|
||
| # Initialize TPM (keep at bottom) | ||
| run-shell ~/.tmux/plugins/tpm/tpm |
There was a problem hiding this comment.
P2: This hardcoded TPM bootstrap path is not provisioned by the repository's Home Manager tmux setup, so tmux will try to source a missing script on reload/startup.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At home-manager/programs/tmux/tmux.conf, line 177:
<comment>This hardcoded TPM bootstrap path is not provisioned by the repository's Home Manager tmux setup, so tmux will try to source a missing script on reload/startup.</comment>
<file context>
@@ -168,4 +168,12 @@ set -g history-limit 2147483647
+set -g @plugin 'Ataraxy-Labs/opensessions'
+
+# Initialize TPM (keep at bottom)
+run-shell ~/.tmux/plugins/tpm/tpm
+
# Persistent session history logger is managed by launchd/systemd.
</file context>
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "amp.url": "http://localhost:8317" | |||
| "amp.url": "https://ampcode.com" | |||
There was a problem hiding this comment.
P2: Keep AMP pointed at the local proxy. This change bypasses the repository’s localhost:8317 integration and sends requests straight to the upstream service instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At config/amp/settings.json, line 2:
<comment>Keep AMP pointed at the local proxy. This change bypasses the repository’s `localhost:8317` integration and sends requests straight to the upstream service instead.</comment>
<file context>
@@ -1,3 +1,3 @@
{
- "amp.url": "http://localhost:8317"
+ "amp.url": "https://ampcode.com"
}
</file context>
| "amp.url": "https://ampcode.com" | |
| "amp.url": "http://localhost:8317" |
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="config/cliproxyapi/config.template.yaml">
<violation number="1" location="config/cliproxyapi/config.template.yaml:42">
P2: The commented AMP template lost its YAML indentation, so uncommenting it produces an invalid or mis-scoped config.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| - from: "claude-sonnet-4-6-thinking" | ||
| to: "gemini-claude-sonnet-4-6-thinking" | ||
| # ampcode: | ||
| # upstream-url: "https://ampcode.com" |
There was a problem hiding this comment.
P2: The commented AMP template lost its YAML indentation, so uncommenting it produces an invalid or mis-scoped config.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At config/cliproxyapi/config.template.yaml, line 42:
<comment>The commented AMP template lost its YAML indentation, so uncommenting it produces an invalid or mis-scoped config.</comment>
<file context>
@@ -39,17 +39,17 @@ quota-exceeded:
- # to: "gemini-claude-sonnet-4-6"
- # - from: "claude-sonnet-4-6-thinking"
- # to: "gemini-claude-sonnet-4-6-thinking"
+# upstream-url: "https://ampcode.com"
+# upstream-api-key: "__AMP_UPSTREAM_API_KEY__"
+# restrict-management-to-localhost: false
</file context>
1 participant
Summary by cubic
Add OpenSessions support via a tmux plugin and Ghostty keybinds to streamline session navigation. Also enables AMP integration in templates, updates Claude settings, and adjusts packages for stability.
New Features
Ataraxy-Labs/opensessionsTPM plugin intmuxand initialize TPM.Refactors
amp.urltohttps://ampcode.com; uncommentampcodesettings and model mappings incliproxyapitemplates."effortLevel": "high"; add env flags (CLAUDE_CODE_DISABLE_*,CLAUDE_CODE_SUBAGENT_MODEL=sonnet); remove duplicateCLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS.custom_modelsfromfactory/config.json; keep"completionSound": "off".vllmtox86_64-linux, keepqwen-codefor non-aarch64-linux; addtmux; remove@latestfromclaude-codeandcodex.Written for commit ae85636. Summary will update on new commits.