fix(npm-globals): Prune stale Bun globals by shunkakinoki · Pull Request #1448 · shunkakinoki/dotfiles

shunkakinoki · 2026-04-12T12:16:48Z

Prune stale Bun globals when syncing npm globals.

The npm-global installer only added or updated packages listed in dotfiles/package.json, so packages removed from that manifest could stay behind in ~/.bun/install/global and keep stale shims like ~/.bun/bin/bd alive. That left Bun state inconsistent and could shadow the repo-local bd binary until manually deleted.

This change prunes Bun global dependencies that are no longer declared, falls back to removing stale metadata if Bun leaves it behind, and sweeps dangling shims from ~/.bun/bin. It also adds a shell regression spec covering the stale @beads/bd case.

Summary by cubic

Prunes stale Bun globals during npm-global sync to keep the PATH clean and prevent repo binaries from being shadowed. Removes undeclared packages and dangling shims, covering the @beads/bd case.

Bug Fixes
- Remove globals not declared in dotfiles (runs bun remove, prunes leftover metadata, deletes modules).
- Sweep dangling shims in ~/.bun/bin to clear broken commands.
- Add shell regression spec for @beads/bd.

^{Written for commit 257dc0a. Summary will update on new commits.}

Remove packages from Bun global state when they are no longer declared in dotfiles/package.json instead of only installing missing packages. Also clean dangling shims in ~/.bun/bin and cover the stale @beads/bd case with shell specs so the local repo binary remains the only bd on PATH. Co-authored-by: Codex <noreply@openai.com>

mesa-dot-dev · 2026-04-12T12:16:52Z

You do not have enough credits to review this pull request. Please purchase more credits to continue.

coderabbitai · 2026-04-12T12:17:01Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b2aa7294-1b55-4742-aca9-1843ff958584

📥 Commits

Reviewing files that changed from the base of the PR and between 376c8a1 and 257dc0a.

📒 Files selected for processing (2)

home-manager/modules/npm-globals/install-npm-globals.sh
spec/npm_globals_spec.sh

Disabled knowledge base sources:

Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📝 Walkthrough

Summary by CodeRabbit

Release Notes

New Features
- Added automatic cleanup of stale global package dependencies no longer present in your configuration
- Removal of orphaned package manager shim files from your system
Tests
- Added comprehensive test suite to validate global package cleanup functionality

Walkthrough

This PR adds logic to remove stale Bun global packages no longer present in the dotfiles package.json file, including cleanup of corresponding entries from the Bun global package registry and removal of dangling symlink shims, while reorganizing variable assignment order in the install script.

Changes

Cohort / File(s)	Summary
Stale Bun Global Pruning `home-manager/modules/npm-globals/install-npm-globals.sh`	Introduces computation and removal of stale Bun global dependencies by deleting entries from `~/.bun/install/global/package.json`, removing associated `node_modules` directories, and cleaning up dangling symlinks under `~/.bun/bin`. Reorganizes script to assign `GLOBAL_PKG` earlier before stale-package removal logic executes.
Pruning Test Coverage `spec/npm_globals_spec.sh`	Adds new test suite section validating stale Bun global package removal, including mocked `bun remove` command behavior, verification that stale package entries are deleted from the global package.json, and confirmation that corresponding shim files are removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat(openclaw): enable memory-wiki plugin and bump to 2026.4.8 #1408: Modifies the same install-npm-globals.sh script, switching batch installs to per-package installs for Bun globals.
fix: skip installed npm globals and prevent nvim lua typechange #1380: Updates the npm-globals installer with skip-installed/version checks and batching logic for Bun package handling.
fix: deduplicate nested pino in global paperclipai install #1355: Adds post-install cleanup behavior (deduplication) for nested Bun global packages in the same script.

Poem

🐰 Hop, skip, and clean those symlinks away!
Stale packages banished, fresh starts today,
Dangling shims removed without delay,
Bun's globals pruned in the most tidy way! 🌿✨

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch shunkakinoki/fix/prune-stale-bun-globals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mesa-dot-dev · 2026-04-12T12:17:14Z

Mesa Description

TL;DR

Fixes the npm-global installer to prune stale Bun global packages and shims, resolving inconsistencies and preventing shadowed binaries.

What changed?

Modified the npm-global installer to prune undeclared Bun global dependencies.
Added logic to remove stale Bun metadata if left behind.
Implemented sweeping of dangling shims from ~/.bun/bin.
Added a shell regression spec to cover the stale @beads/bd case.

^{Description generated by Mesa. Update settings}

gemini-code-assist

Code Review

This pull request introduces logic to prune stale global packages and dangling shims in the Bun environment. It adds a process to compare installed global packages against the dependencies declared in the configuration's package.json, removing any that are no longer required. Additionally, it implements a cleanup step for broken symbolic links in the Bun binary directory and includes comprehensive tests for these new features. A review comment suggests improving the robustness of the shim cleanup loop by using IFS= read -r to correctly handle filenames that may contain whitespace.

gemini-code-assist · 2026-04-12T12:18:17Z

+# Remove stale shims left behind by prior Bun global installs
+BUN_BIN="${HOME}/.bun/bin"
+if [ -d "$BUN_BIN" ]; then
+  find "$BUN_BIN" -mindepth 1 -maxdepth 1 -type l 2>/dev/null | while read -r shim; do


To robustly parse the output of the find command and avoid issues with filenames that might contain leading or trailing whitespace, you should use IFS= read -r. This aligns with the general rule for robustly parsing command output and maintains consistency with the while loop used earlier in the script (line 57).

Suggested change

find "$BUN_BIN" -mindepth 1 -maxdepth 1 -type l 2>/dev/null | while read -r shim; do

find "$BUN_BIN" -mindepth 1 -maxdepth 1 -type l 2>/dev/null | while IFS= read -r shim; do

References

To robustly parse command output in shell scripts, use a unique delimiter (e.g., tab) in the format string and read with a matching IFS. This is safer than splitting by spaces with cut, especially when data fields might contain spaces.

shunkakinoki merged commit 16532f4 into main Apr 12, 2026
29 of 30 checks passed

shunkakinoki deleted the shunkakinoki/fix/prune-stale-bun-globals branch April 12, 2026 12:17

gemini-code-assist Bot reviewed Apr 12, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jun 4, 2026

fix(npm-globals): install platform-native binaries for claude-code and codex #1890

Merged

5 tasks

Navigation Menu

fix(npm-globals): Prune stale Bun globals - #1448

fix(npm-globals): Prune stale Bun globals#1448
shunkakinoki merged 1 commit into
mainfrom
shunkakinoki/fix/prune-stale-bun-globals

shunkakinoki commented Apr 12, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

mesa-dot-dev Bot commented Apr 12, 2026

Uh oh!

coderabbitai Bot commented Apr 12, 2026 •

edited

Loading

Review failed

Summary by CodeRabbit

Release Notes

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

mesa-dot-dev Bot commented Apr 12, 2026

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	find "$BUN_BIN" -mindepth 1 -maxdepth 1 -type l 2>/dev/null \| while read -r shim; do
	find "$BUN_BIN" -mindepth 1 -maxdepth 1 -type l 2>/dev/null \| while IFS= read -r shim; do

Conversation

shunkakinoki commented Apr 12, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

mesa-dot-dev Bot commented Apr 12, 2026

Uh oh!

coderabbitai Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Summary by CodeRabbit

Release Notes

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

mesa-dot-dev Bot commented Apr 12, 2026

Mesa Description

TL;DR

What changed?

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

shunkakinoki commented Apr 12, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Apr 12, 2026 •

edited

Loading