refactor: move openclaw, paperclip, obsidian from modules to services - #1447
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR reorganizes home-manager modules by removing Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRMoved What changed?
Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Code Review
This pull request migrates the obsidian, openclaw, and paperclip modules from home-manager/modules to home-manager/services, consolidating service definitions, file paths, and test specifications. Feedback was provided to standardize the arguments passed to service imports across all modules to ensure consistency and improve maintainability.
| openclaw = import ./openclaw { | ||
| inherit | ||
| config | ||
| lib | ||
| pkgs | ||
| inputs |
There was a problem hiding this comment.
The imports for openclaw and paperclip are added here with config, lib, pkgs, and inputs passed as arguments. This matches the function signature in their respective default.nix files. However, note that obsidian and ollama (lines 20-21) only take pkgs and inputs. While this is currently correct based on the individual file requirements, maintaining a consistent interface for all service modules (e.g., always passing config, lib, pkgs, inputs) would improve maintainability and make it easier to add features like options to those modules in the future.
Summary
home-manager/modules/tohome-manager/services/since they define systemd servicesobsidian-headless.shto services dir)Test plan
make shell-testpasses (1228 examples, 0 failures)nix flake check --no-buildevaluates successfullySummary by cubic
Move
openclaw,paperclip, andobsidianfromhome-manager/modulestohome-manager/servicesand fold Obsidian’s module logic into its service to match the systemd service layout. Updates imports (now consistently formatted) and tests; no functional changes.openclawandpapercliptohome-manager/services/; added and formatted imports inhome-manager/services/default.nix.obsidianwrapper and defining the user service inservices/obsidian; switchedpkgs.replaceVarsto use./obsidian-headless.shin the service directory.home-manager/modules/default.nixand updated test specs to the new paths.Written for commit 90254ce. Summary will update on new commits.