fix: add --disable-gpu to obsidian headless wrapper - #1434
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 1 minutes and 17 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRAdds What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the --disable-gpu flag to the obsidian-headless.sh script to improve its performance in headless environments. The review feedback suggests further enhancing stability by adding the --disable-software-rasterizer and --disable-dev-shm-usage flags to the execution command to prevent potential crashes in shared memory constrained environments.
| @@ -1,2 +1,2 @@ | |||
| #!/usr/bin/env bash | |||
| exec @xvfbRun@/bin/xvfb-run -a @obsidian@/bin/obsidian --no-sandbox "$@" | |||
| exec @xvfbRun@/bin/xvfb-run -a @obsidian@/bin/obsidian --no-sandbox --disable-gpu "$@" | |||
There was a problem hiding this comment.
To ensure maximum compatibility and stability in headless environments, consider adding --disable-software-rasterizer and --disable-dev-shm-usage alongside --disable-gpu.
--disable-software-rasterizer: Prevents Electron from falling back to software-based GL rendering, which can still cause issues on some headless hosts.--disable-dev-shm-usage: Prevents crashes in environments where the shared memory partition (/dev/shm) is too small, a common issue in headless or containerized setups.
| exec @xvfbRun@/bin/xvfb-run -a @obsidian@/bin/obsidian --no-sandbox --disable-gpu "$@" | |
| exec @xvfbRun@/bin/xvfb-run -a @obsidian@/bin/obsidian --no-sandbox --disable-gpu --disable-software-rasterizer --disable-dev-shm-usage "$@" |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds the --disable-gpu Chromium/Electron flag to the Obsidian headless wrapper to avoid GLX/ANGLE initialization errors on headless hosts without GPU support (follow-up to #1433).
Changes:
- Append
--disable-gputo the Obsidian invocation in thexvfb-runwrapper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
--disable-gpuflag to the obsidian headless wrapper to prevent GLX/ANGLE initialization errors on kyber (headless host without GPU)--no-sandboxTest plan
obsidianCLIANGLE Display::initialize error/GLX is not presentstderr spamSummary by cubic
Add --disable-gpu to the Obsidian headless wrapper to prevent GLX/ANGLE initialization errors on GPU-less hosts (e.g., kyber) and stop stderr spam. Follows up on #1433 which added --no-sandbox.
Written for commit d05bce9. Summary will update on new commits.