feat: advertise kyber as Tailscale exit node - #1431
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughA single-line configuration addition to a Nix Home Manager Tailscale setup, appending the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRAdds What changed?File summaries not provided. Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the --advertise-exit-node flag to the Tailscale configuration for the kyber host. The reviewer suggests using the native advertiseExitNode option instead of manual flags for better maintainability. Additionally, it was noted that the configuration may not be applied automatically as the tailscale-up service is currently disabled for this host.
| extraUpArgs = [ | ||
| "--reset" | ||
| "--accept-dns=false" | ||
| "--advertise-exit-node" | ||
| ]; |
There was a problem hiding this comment.
The tailscale module already provides a dedicated advertiseExitNode boolean option. It is better to use this option instead of passing the flag manually through extraUpArgs for better maintainability.
Functionality Warning: The tailscale-up service (which applies these arguments) is only enabled in the module when serviceConfig is non-empty. Since serviceConfig is currently omitted for kyber, these settings will not be applied automatically upon deployment. You will likely need to run tailscale up manually or update the configuration to enable the automated service.
advertiseExitNode = true;
extraUpArgs = [
"--reset"
"--accept-dns=false"
];
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR aims to configure the kyber host’s Tailscale setup to advertise itself as an exit node so other devices (e.g., galactica) can route all traffic through it.
Changes:
- Add
--advertise-exit-nodeto kyber’s TailscaleextraUpArgs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| extraUpArgs = [ | ||
| "--reset" | ||
| "--accept-dns=false" | ||
| "--advertise-exit-node" | ||
| ]; |
Summary
--advertise-exit-nodeto kyber's Tailscale config so galactica and other devices can route all traffic through kyberSetup after merge
sudo sysctl -w net.ipv4.ip_forward=1tailscale set --exit-node=kyberSummary by cubic
Adds
--advertise-exit-nodeto kyber’stailscaleconfig so galactica and other devices can route all traffic through kyber.sudo sysctl -w net.ipv4.ip_forward=1tailscale set --exit-node=kyberWritten for commit 1db495a. Summary will update on new commits.