fix: update Qwen model names in fish tests to match functions - #1424
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates test expectations across six Fish test files to validate a different Qwen model identifier, changing from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRUpdated Qwen model names in 6 fish test files to What changed?Updated 6 fish test files to use Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Fish shell test specifications to reflect a change in the default Qwen model, switching from qwen3.5-9b to qwen3.5-0.8b-optiq across multiple test files including _coxel, _ocxel, and _pixel functions. I have no feedback to provide as there were no review comments to evaluate.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="spec/fish/_pixel_function_test.fish">
<violation number="1" location="spec/fish/_pixel_function_test.fish:10">
P3: Use literal matching for the model-name assertion. With regex `grep`, dots in `qwen3.5-0.8b-optiq` are wildcards, so the test can pass without an exact model string match.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| _pixel_function | ||
|
|
||
| @test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen/qwen3.5-9b" $log1) -ge 1 | ||
| @test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1 |
There was a problem hiding this comment.
P3: Use literal matching for the model-name assertion. With regex grep, dots in qwen3.5-0.8b-optiq are wildcards, so the test can pass without an exact model string match.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At spec/fish/_pixel_function_test.fish, line 10:
<comment>Use literal matching for the model-name assertion. With regex `grep`, dots in `qwen3.5-0.8b-optiq` are wildcards, so the test can pass without an exact model string match.</comment>
<file context>
@@ -7,7 +7,7 @@ function pi; echo $argv >> $log1; end
_pixel_function
-@test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen/qwen3.5-9b" $log1) -ge 1
+@test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1
# ── with args: builds prompt ──────────────────────────────
</file context>
| @test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1 | |
| @test "no args calls pi with local Qwen model" (grep -F -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates fish specs to assert against the current local Qwen model name (qwen3.5-0.8b-optiq) instead of older qwen/qwen3.5-9b strings so the tests match the actual functions.
Changes:
- Updated
_pixel*fish specs to grep forlmstudio/qwen3.5-0.8b-optiq. - Updated
_ocxel*fish specs to grep forlmstudio/qwen3.5-0.8b-optiq. - Updated
_coxel*fish specs to grep forqwen3.5-0.8b-optiq.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/fish/_pixelh_function_test.fish | Updates model-name assertion for _pixelh_function tests |
| spec/fish/_pixel_function_test.fish | Updates model-name assertions for _pixel_function tests |
| spec/fish/_ocxelh_function_test.fish | Updates model-name assertion for _ocxelh_function tests |
| spec/fish/_ocxel_function_test.fish | Updates model-name assertions for _ocxel_function tests |
| spec/fish/_coxelh_function_test.fish | Updates substituted model-name assertion for _coxelh_function tests |
| spec/fish/_coxel_function_test.fish | Updates substituted model-name assertions for _coxel_function tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _pixel_function | ||
|
|
||
| @test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen/qwen3.5-9b" $log1) -ge 1 | ||
| @test "no args calls pi with local Qwen model" (grep -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1 |
There was a problem hiding this comment.
grep patterns are regex by default, so the . characters in qwen3.5-0.8b-optiq match any character. Since these assertions are intended to match an exact model string, use fixed-string matching (e.g., grep -F) or escape the dots to avoid accidental matches and make the tests more robust.
|
|
||
| @test "non-empty prompt builds prompt" (grep -c "hello world" $log1) -ge 1 | ||
| @test "non-empty prompt uses local Qwen model" (grep -c "lmstudio/qwen/qwen3.5-9b" $log1) -ge 1 | ||
| @test "non-empty prompt uses local Qwen model" (grep -c "lmstudio/qwen3.5-0.8b-optiq" $log1) -ge 1 |
There was a problem hiding this comment.
The expected model name literal is duplicated across multiple fish spec files in this PR. To reduce churn the next time the model name changes, consider centralizing it (e.g., a shared test helper / common variable sourced by these specs, or at least a local set expected_model ... at the top of each file) and referencing that in the assertions.
Updated 6 fish test files to use qwen3.5-0.8b-optiq model name matching the actual functions. Tests were referencing old qwen/qwen3.5-9b model.
Summary by cubic
Update fish tests to expect the
qwen3.5-0.8b-optiqmodel (withlmstudiolocal provider), matching the functions and preventing false negatives. Replaces oldqwen/qwen3.5-9bandlmstudio/qwen/qwen3.5-9bassertions.Written for commit 849bac9. Summary will update on new commits.