all commitall - #1398
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates project dependencies across three configuration files: Rust's worktrunk from 0.33.0 to 0.34.2, npm packages (11 version increments), and introduces new Make targets for coordinated lock file regeneration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRUpdated project dependencies and build configuration. What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies in Cargo.toml and package.json, along with their corresponding lock files. It also introduces new Makefile targets for updating lock files, specifically adding update-lock and cargo-update. Feedback points out a potential naming inconsistency for the Nix update dependency and raises concerns about the use of the nightly Rust toolchain and unstable flags in the build process.
| update: nix-update neovim-update gitalias-update llm-update overlays-update ## Update Nix flake, overlays, Neovim plugins, LLM configs, gitalias, and bun deps | ||
|
|
||
| .PHONY: update-lock | ||
| update-lock: nix-flake-update bun-update cargo-update ## Update lock files for Nix flake, bun, and Cargo. |
There was a problem hiding this comment.
The update-lock target depends on nix-flake-update, which is not defined in the visible portions of the Makefile, while the update target (line 247) uses nix-update. This inconsistency may lead to failures if nix-flake-update is missing or was intended to be nix-update.
| .PHONY: cargo-update | ||
| cargo-update: ## Update Rust dependencies to latest and regenerate lock file. | ||
| @echo "🦀 Updating Cargo dependencies..." | ||
| @cargo +nightly update --breaking -Z unstable-options |
There was a problem hiding this comment.
Using cargo +nightly with unstable flags (-Z unstable-options, --breaking) introduces a hard dependency on the nightly toolchain and experimental features. This can lead to reproducibility issues and failures in environments where only the stable toolchain is available.
There was a problem hiding this comment.
Pull request overview
Updates Rust and Bun dependencies (and their lockfiles) and adds Make targets to streamline regenerating lock files across the repo.
Changes:
- Bump various Bun dependencies (package.json + bun.lock), including
@github/copilot,vite,oxfmt,oxlint, and others. - Bump Rust crate
worktrunkto0.34.2(Cargo.toml + Cargo.lock). - Add
update-lockandcargo-updatetargets to the Makefile to automate lockfile refreshes.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Bun dependency versions. |
| bun.lock | Regenerates Bun lockfile to reflect updated dependencies. |
| Cargo.toml | Bumps worktrunk dependency version. |
| Cargo.lock | Updates Cargo lockfile to the new worktrunk version. |
| Makefile | Adds update-lock and cargo-update targets for lockfile/dependency update workflows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .PHONY: update-lock | ||
| update-lock: nix-flake-update bun-update cargo-update ## Update lock files for Nix flake, bun, and Cargo. | ||
|
|
There was a problem hiding this comment.
update-lock claims to only update lock files, but it invokes bun-update, which runs bun update --latest --recursive and will also modify dependency versions in package.json (not just bun.lock). Consider renaming the target / adjusting the description, or splitting into separate targets (e.g., one that only regenerates bun.lock via bun install, and another that bumps dependency ranges).
| .PHONY: cargo-update | ||
| cargo-update: ## Update Rust dependencies to latest and regenerate lock file. | ||
| @echo "🦀 Updating Cargo dependencies..." | ||
| @cargo +nightly update --breaking -Z unstable-options | ||
| @echo "✅ Cargo dependencies updated" | ||
|
|
There was a problem hiding this comment.
cargo-update uses cargo +nightly update --breaking -Z unstable-options, which forces nightly Cargo and explicitly opts into semver-breaking dependency updates. If this target is meant for routine updates, consider making breaking updates opt-in (e.g., a separate cargo-update-breaking target or a flag variable) and/or add a short guard/error message when rustup/cargo aren’t available so failures are clearer.
| .PHONY: cargo-update | |
| cargo-update: ## Update Rust dependencies to latest and regenerate lock file. | |
| @echo "🦀 Updating Cargo dependencies..." | |
| @cargo +nightly update --breaking -Z unstable-options | |
| @echo "✅ Cargo dependencies updated" | |
| .PHONY: cargo-update cargo-update-breaking | |
| cargo-update: ## Update Rust dependencies and regenerate lock file. | |
| @echo "🦀 Updating Cargo dependencies..." | |
| @command -v cargo >/dev/null 2>&1 || { echo "❌ cargo is required for 'make cargo-update'"; exit 1; } | |
| @cargo update | |
| @echo "✅ Cargo dependencies updated" | |
| cargo-update-breaking: ## Update Rust dependencies with semver-breaking upgrades (requires rustup nightly). | |
| @echo "🦀 Updating Cargo dependencies with breaking changes..." | |
| @command -v rustup >/dev/null 2>&1 || { echo "❌ rustup is required for 'make cargo-update-breaking'"; exit 1; } | |
| @command -v cargo >/dev/null 2>&1 || { echo "❌ cargo is required for 'make cargo-update-breaking'"; exit 1; } | |
| @cargo +nightly update --breaking -Z unstable-options | |
| @echo "✅ Cargo dependencies updated with breaking changes" |
Summary
All commitall
Files Changed
Total changes: 196 insertions(+), 107 deletions(-)
Summary by cubic
Upgrade Rust and JS toolchains and add Makefile helpers for lockfile maintenance. Highlights include
worktrunk0.34.2,vite8.0.5, and refreshed lint/format tools.Dependencies
worktrunk→ 0.34.2 (Cargo.toml/lock).vite→ 8.0.5,vite-plus→ 0.1.16,oxfmt→ 0.44.0,oxlint→ 1.59.0.@github/copilot→ 1.0.19,@sourcegraph/ampbump,@traces-sh/traces→ 0.4.15,@upstash/context7-mcp→ 2.1.7.bun.lockandpackage.jsonto match.New Features
update-lock(nix/bun/Cargo) andcargo-update(runscargo +nightly update --breaking) to streamline dependency updates.Written for commit e6a5ecf. Summary will update on new commits.