Skip to content

fix: batch bun global installs to prevent resolution hang #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 3 commits into from
Apr 5, 2026
Merged

fix: batch bun global installs to prevent resolution hang #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d98cf94
fix: resolve upgrade CI failure from dotagents sync target collision
shunkakinoki Apr 5, 2026
f7c77e5
fix: batch bun global installs to prevent resolution hang
shunkakinoki Apr 5, 2026
d77dad8
Merge branch 'main' into 1372-fix-upgrade-ci
shunkakinoki Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions home-manager/modules/npm-globals/install-npm-globals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,21 @@ if [ -n "$TRUSTED_DEPS" ]; then
done
fi

# Install global packages
# Install global packages in batches (bun hangs when resolving too many at once)
DEPS=$(jq -r '.dependencies | keys[]' "$PACKAGE_JSON" 2>/dev/null || true)
if [ -n "$DEPS" ]; then
# shellcheck disable=SC2086
bun install --global $DEPS 2>/dev/null || true
BATCH_SIZE=10
BATCH=()
while IFS= read -r dep; do
BATCH+=("$dep")
if [ "${#BATCH[@]}" -ge "$BATCH_SIZE" ]; then
bun add --global "${BATCH[@]}" 2>/dev/null || true
BATCH=()
fi
done <<< "$DEPS"
if [ "${#BATCH[@]}" -gt 0 ]; then
bun add --global "${BATCH[@]}" 2>/dev/null || true
fi
fi

# Apply dependency overrides to the global install
Expand Down
11 changes: 8 additions & 3 deletions spec/npm_globals_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,14 @@ When run bash -c "grep 'trustedDependencies' '$SCRIPT'"
The output should include 'trustedDependencies'
End

It 'uses bun install --global'
When run bash -c "grep 'bun install --global' '$SCRIPT'"
The output should include 'bun install --global'
It 'uses bun add --global in batches'
When run bash -c "grep 'bun add --global' '$SCRIPT'"
The output should include 'bun add --global'
End

It 'batches packages to avoid bun resolution hangs'
When run bash -c "grep 'BATCH_SIZE' '$SCRIPT'"
The output should include 'BATCH_SIZE'
End

It 'parses dependencies with jq'
Expand Down
Loading