Skip to content

fix: remove EnvironmentFile from paperclip service #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Apr 4, 2026
Merged

fix: remove EnvironmentFile from paperclip service #1344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion home-manager/modules/paperclip/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ lib.mkIf host.isKyber {
"HOME=${homeDir}"
"PATH=${homeDir}/.local/bin:${homeDir}/.bun/bin:${homeDir}/.nix-profile/bin:${homeDir}/.local/share/pnpm:${homeDir}/.local/share/fnm/current/bin:${homeDir}/.npm-global/bin:/usr/local/bin:/usr/bin:/bin"
];
EnvironmentFile = "${instanceDir}/.env";

@gemini-code-assist gemini-code-assist Bot Apr 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the EnvironmentFile reference makes the instanceDir variable (defined on line 10) unused within this module. To maintain code cleanliness and avoid confusion, consider removing the instanceDir definition as well.

WorkingDirectory = "${homeDir}/.paperclip";
StandardOutput = "append:/tmp/paperclip/paperclip.log";
StandardError = "append:/tmp/paperclip/paperclip.log";
Comment on lines 41 to 43

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service logs to /tmp/paperclip/paperclip.log, but /tmp is typically cleared on reboot and the Home Manager activation hook won’t run at user-service start. This can cause the unit to fail if the directory is missing. Prefer creating the directory in the unit itself (e.g., RuntimeDirectory/StateDirectory + %t for the path, or an ExecStartPre mkdir) so it’s always present with correct ownership/permissions.

Copilot uses AI. Check for mistakes.
Expand Down
Loading