Repository navigation
fix: remove cargo update to preserve Cargo.lock versions #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -158,7 +158,7 @@ build_repo() { | |||||||||
| return 1 | ||||||||||
| fi | ||||||||||
| elif [ -f "$build_dir/Cargo.toml" ]; then | ||||||||||
| if (cd "$build_dir" && cargo update 2>&1 && cargo +nightly build --release 2>&1); then | ||||||||||
| if (cd "$build_dir" && cargo +nightly build --release 2>&1); then | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To fully adhere to the goal of preserving
Suggested change
|
||||||||||
| if (cd "$build_dir" && cargo +nightly build --release 2>&1); then | |
| if (cd "$build_dir" && cargo +nightly build --release --locked 2>&1); then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
cargo updatepreserves upstream dependency versions, which is good for reproducibility. However, this script doesn't appear to pull/update the git repositories before building. Consider adding agit pullor similar mechanism to ensure you're building the latest upstream code, otherwise you may be building stale versions with stale dependencies. This would be particularly important if these repositories receive security updates.Prompt for Agent