refactor(git): reorganize global ignore entries - #1256
Conversation
Entire-Checkpoint: 04088a6adeb6
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughConfiguration updates applied to gomi's UI theme, switching the color scheme from nord to dracula and adjusting various color hex values. Global gitignore patterns reorganized to consolidate AI-related directories, environment files, and temporary files at the top of the file without functional changes to ignored paths. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the global Git ignore file ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Mesa DescriptionTL;DRReorganized the global gitignore to group tool-specific, temporary, and environment-only files more consistently, adding new ignores for local agent and workspace state. Also updated the What changed?
Description generated by Mesa. Update settings |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively reorganizes the global .gitignore file, making it much cleaner and easier to maintain. The grouping of ignore patterns into logical sections is a great improvement. I've added a couple of minor suggestions to further refine the organization and remove a redundant pattern. Overall, this is a solid refactoring.
| .conductor/ | ||
| .cursor/ | ||
| .entire/ | ||
| .pi/ | ||
| .serena/ | ||
| .worktrees/ | ||
|
|
||
| # Env files | ||
| .env.* | ||
| .env.local | ||
| .envrc | ||
|
|
||
| # Other | ||
| .cache/ | ||
| .devenv/ | ||
| .jj/ |
There was a problem hiding this comment.
The .worktrees/ entry seems misplaced under the # AI section. git worktree is a core Git feature for managing multiple working trees and is not related to AI. To improve the logical grouping, consider moving it to the # Other section, which contains other development-related artifacts.
.conductor/
.cursor/
.entire/
.pi/
.serena/
# Env files
.env.*
.env.local
.envrc
# Other
.cache/
.devenv/
.jj/
.worktrees/
| tmp | ||
| .tmp* | ||
| tmp* |
There was a problem hiding this comment.
The tmp pattern is redundant because the tmp* pattern already covers any file or directory named tmp. You can remove the tmp line to simplify the configuration.
.tmp*
tmp*
Entire-Checkpoint: 6713b21a1de4
Entire-Checkpoint: 0c4cf218df34
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR refactors the Home Manager global gitignore file to be easier to scan/extend while adding ignores for additional machine-local tool/workspace state, and updates the gomi UI theme colors.
Changes:
- Reorganized
home-manager/programs/git/.gitignore.globalinto clearer grouped sections and added several new local-state ignore patterns. - Switched
gomipreview colorscheme todraculaand updated UI color values accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| home-manager/programs/git/.gitignore.global | Regroups global ignore patterns and adds entries for additional local agent/workspace directories. |
| config/gomi/config.yaml | Updates gomi UI theme to Dracula with corresponding color palette changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Env files | ||
| .env.* | ||
| .env.local |
There was a problem hiding this comment.
The .env.local entry is redundant because it’s already matched by the preceding .env.* pattern. Consider removing .env.local (or narrowing the glob if you intended to exclude only certain .env.* files).
| .env.local |
| .jj/ | ||
|
|
||
| # Tmp files | ||
| tmp |
There was a problem hiding this comment.
In the tmp section, tmp* already matches tmp (since * can match an empty string), so keeping both is redundant. Consider dropping the plain tmp entry unless you specifically want it to stand out separately.
| tmp |
Reorganize .gitignore.global so tool-specific, temporary, and environment-only files are grouped consistently.\n\nThis adds missing ignores for local agent and workspace state such as .conductor/, .pi/, .worktrees/, .cache/, .devenv/, and .jj/, while keeping the existing env, tmp, and deprecated-file patterns in clearer sections. That keeps machine-local artifacts out of commits and makes the global ignore list easier to scan and extend.\n\nI considered appending the new entries in place, but regrouping the existing patterns now avoids duplicate categories and keeps the non-macOS ignores in one predictable block.
Summary by cubic
Reorganized
.gitignore.globalinto clear sections and added missing local tool and workspace directories. Also updatedgomiUI to the dracula colorscheme and cleaned up its config..conductor/,.cursor/,.entire/,.pi/,.serena/,.worktrees/,.cache/,.devenv/,.jj/.Written for commit 61af881. Summary will update on new commits.