Skip to content

chore(omp): manage config via dotfiles templates #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 3 commits into from
Mar 20, 2026
Merged

chore(omp): manage config via dotfiles templates #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2425d2
chore(omp): manage config via dotfiles templates
shunkakinoki Mar 19, 2026
aa699c1
fix(omp): disable double escape action
shunkakinoki Mar 20, 2026
96842af
Merge remote-tracking branch 'origin/main' into chore/omp-dotfiles-co…
shunkakinoki Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ in
./karabiner
./llm
./openclaw
./omp
./opencode
./pi
./serena
Expand Down
13 changes: 13 additions & 0 deletions config/omp/config.tpl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
lastChangelogVersion: 13.13.2
modelRoles:
default: codex/__GPT__

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the generated config keeps the default role on codex/__GPT__, but scripts/llm-update.sh replaces __GPT__ placeholders with the concrete value from models.json (so the generated config.yml becomes codex/gpt-5.4). Please update the PR description or adjust the template/substitution behavior if you intended the placeholder to remain in the generated file.

Copilot uses AI. Check for mistakes.
display:
showTokenUsage: true
theme:
dark: dark-dracula
steeringMode: all
followUpMode: all
interruptMode: immediate
doubleEscapeAction: none
startup:
quiet: true
13 changes: 13 additions & 0 deletions config/omp/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
lastChangelogVersion: 13.13.2
modelRoles:
default: codex/gpt-5.4
display:
showTokenUsage: true
theme:
dark: dark-dracula
steeringMode: all
followUpMode: all
interruptMode: immediate
doubleEscapeAction: none
startup:
quiet: true
10 changes: 10 additions & 0 deletions config/omp/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{ lib, ... }:
{
# Use activation script instead of home.file symlink.
# Keep only the tracked config.yml in dotfiles and leave runtime state untouched.
home.activation.ompConfig = lib.hm.dag.entryAfter [ "writeBoundary" ] ''
$DRY_RUN_CMD mkdir -p ~/.omp/agent
$DRY_RUN_CMD cp -f ${./config.yml} ~/.omp/agent/config.yml
$DRY_RUN_CMD chmod 644 ~/.omp/agent/config.yml
Comment on lines +6 to +8

@gemini-code-assist gemini-code-assist Bot Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better robustness in shell scripting within Nix expressions, it's preferable to use the $HOME environment variable instead of the tilde ~ for referring to the user's home directory. While ~ often works, $HOME is more explicit and less prone to expansion issues in certain shell contexts. Quoting the path is also a good practice to handle potential special characters.

    $DRY_RUN_CMD mkdir -p "$HOME"/.omp/agent
    $DRY_RUN_CMD cp -f ${./config.yml} "$HOME"/.omp/agent/config.yml
    $DRY_RUN_CMD chmod 644 "$HOME"/.omp/agent/config.yml

Comment on lines +7 to +8

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The activation script installs the OMP config with mode 644, which makes it world-readable if the user's home directory is not 0700. If this file can ever contain tokens/identifiers (now or in future OMP versions), this is an avoidable information exposure; prefer chmod 600 (matching config/codex/default.nix) and consider also tightening directory perms if needed.

Suggested change
$DRY_RUN_CMD cp -f ${./config.yml} ~/.omp/agent/config.yml
$DRY_RUN_CMD chmod 644 ~/.omp/agent/config.yml
$DRY_RUN_CMD chmod 700 ~/.omp/agent
$DRY_RUN_CMD cp -f ${./config.yml} ~/.omp/agent/config.yml
$DRY_RUN_CMD chmod 600 ~/.omp/agent/config.yml

Copilot uses AI. Check for mistakes.
'';
}
1 change: 1 addition & 0 deletions scripts/llm-update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ declare -A TEMPLATES=(
["config/ccs/glm.settings.tpl.json"]=config/ccs/glm.settings.template.json
["config/codex/config.tpl.toml"]=config/codex/config.toml
["config/cliproxyapi/config.tpl.yaml"]=config/cliproxyapi/config.template.yaml
["config/omp/config.tpl.yml"]=config/omp/config.yml
["config/pi/models.tpl.json"]=config/pi/models.json
["config/pi/settings.tpl.json"]=config/pi/settings.json
["home-manager/programs/fish/functions/_coxe_function.tpl.fish"]=home-manager/programs/fish/functions/_coxe_function.fish
Expand Down
Loading