Skip to content

chore(claude): add granular hook timeouts per event type #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 2 commits into from
Mar 19, 2026
Merged

chore(claude): add granular hook timeouts per event type #1213

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f55e3
chore(claude): add granular hook timeouts per event type
shunkakinoki Mar 19, 2026
1996613
fix(claude): add missing timeout to duplicate dcg hook entry
shunkakinoki Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions config/claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -96,7 +96,7 @@
"hooks": [
{
"command": "git-ai checkpoint claude --hook-input stdin",
"timeout": 10,
"timeout": 15,
"type": "command"
}
],
Expand All @@ -109,13 +109,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -126,6 +126,7 @@
"hooks": [
{
"command": "$HOME/.claude/hooks/rtk-rewrite.sh",
"timeout": 5,
"type": "command"
},
{
Expand All @@ -142,13 +143,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
],
Expand All @@ -158,11 +159,20 @@
"hooks": [
{
"command": "git-ai checkpoint claude --hook-input stdin",
"timeout": 10,
"timeout": 15,
"type": "command"
}
],
"matcher": "Write|Edit|MultiEdit"
},
{
"matcher": "Bash",
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Resolved
"hooks": [
{
"type": "command",
"command": "dcg"
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
Resolved
}
]
Comment on lines +217 to +226
Comment on lines +218 to +226
}
Comment on lines +217 to 227

@gemini-code-assist gemini-code-assist Bot Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This adds a duplicate hook configuration for matcher: "Bash" within the PreToolUse event. An existing configuration for this matcher is already defined on lines 125-158, which includes an asynchronous, safer call to dcg. This new block introduces a synchronous, blocking call to dcg without a timeout, which is redundant and could lead to performance issues or failures if dcg is not present or hangs. This block should be removed to avoid duplication and potential problems.

      }

],
"PermissionRequest": [
Expand All @@ -171,13 +181,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -189,13 +199,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -207,13 +217,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -225,13 +235,13 @@
{
"async": true,
"command": "$HOME/.claude/notify.sh",
"timeout": 10,
"timeout": 3,
"type": "command"
},
{
"async": true,
"command": "$HOME/.claude/pushover.sh",
"timeout": 10,
"timeout": 6,
"type": "command"
}
]
Expand All @@ -243,7 +253,7 @@
{
"async": true,
"command": "jq -c '{timestamp: (now | todate), prompt: .prompt[0:500]}' >> ~/.claude/prompt-history.jsonl",
"timeout": 5,
"timeout": 3,
"type": "command"
}
]
Expand All @@ -254,6 +264,7 @@
"hooks": [
{
"command": "bash -c 'NAME=$(jq -r .name); REPO=$(git rev-parse --show-toplevel); DIR=\"$REPO/.worktrees/$NAME\"; wt switch --create \"$NAME\" --no-cd -y >&2 && echo \"$DIR\"'",
"timeout": 30,
"type": "command"
}
]
Expand All @@ -264,6 +275,7 @@
"hooks": [
{
"command": "bash -c 'WORKTREE_PATH=$(jq -r .worktree_path); BRANCH=$(basename \"$WORKTREE_PATH\"); wt remove \"$BRANCH\" -y >&2'",
"timeout": 30,
"type": "command"
}
]
Expand Down Expand Up @@ -389,4 +401,4 @@
"type": "command"
},
"teammateMode": "tmux"
}
}
Loading