fix: replace shazow/foundry.nix with nixpkgs foundry to fix nightly URL failures - #1131
fix: replace shazow/foundry.nix with nixpkgs foundry to fix nightly URL failures#1131shunkakinoki wants to merge 1 commit into
Conversation
…RL failures The foundry nightly binary downloads were unreliable (hash mismatches and 500 errors from GitHub), causing intermittent CI failures. Switch to the stable nixpkgs foundry package (1.5.1) via a local overlay alias. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the stability of the project's CI pipeline by migrating the Foundry dependency from an unreliable nightly build source to a stable version provided directly by Nixpkgs. This change resolves recurring build failures related to binary downloads, ensuring a more consistent and predictable development environment without altering the core functionality that relies on Foundry. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe flake's dependency management is restructured: the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses intermittent CI failures by replacing the shazow/foundry.nix flake input, which provided unreliable nightly binaries, with the stable foundry package from nixpkgs. The changes involve removing the foundry input from flake.nix and flake.lock, and adding an overlay to alias foundry-bin to the nixpkgs version. The changes are correct and achieve the stated goal. I've added one suggestion to improve the maintainability of the overlays file by merging multiple overlay functions.
| (final: prev: { | ||
| # Use stable nixpkgs foundry instead of shazow/foundry.nix nightly overlay | ||
| # to avoid unreliable nightly binary downloads. | ||
| foundry-bin = prev.foundry; | ||
| }) |
There was a problem hiding this comment.
For better readability and to reduce boilerplate, you could merge this new overlay with the other subsequent inline overlays in this file into a single overlay function. This is a common pattern in Nix development that improves maintainability.
For example, you could combine this overlay with the next one for neovim-unwrapped:
(final: prev: {
# Use stable nixpkgs foundry instead of shazow/foundry.nix nightly overlay
# to avoid unreliable nightly binary downloads.
foundry-bin = prev.foundry;
# Ensure neovim-unwrapped exposes a lua attribute for wrapper consumers (e.g., home-manager)
neovim-unwrapped =
(prev.neovim-unwrapped.overrideAttrs (oldAttrs: {
passthru = (oldAttrs.passthru or { }) // {
lua = prev.lua5_4;
};
}))
// {
lua = prev.lua5_4;
};
})You could apply this pattern to all the separate overlay functions in this list.
There was a problem hiding this comment.
Pull request overview
This PR removes the shazow/foundry.nix nightly overlay/input (which was causing intermittent CI failures due to unreliable nightly release URLs) and switches the configuration to use the stable Foundry package from nixpkgs via a small local overlay alias.
Changes:
- Replace
inputs.foundry.overlayusage with a local overlay that providesfoundry-bin = prev.foundry. - Remove the
foundryflake input fromflake.nix. - Prune the
foundry(and now-unneededflake-utils) nodes/references fromflake.lock.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| overlays/default.nix | Drops the external Foundry overlay and introduces a local alias to nixpkgs’ Foundry package. |
| flake.nix | Removes the foundry flake input definition. |
| flake.lock | Removes the locked foundry dependency graph entries and corresponding root input reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Mesa DescriptionTL;DRReplaced What changed?
Description generated by Mesa. Update settings |
Summary
shazow/foundry.nix(c3aea6faee9fd2fadebccd37c35376bf85d4e524) referencesnightly-d055c0999b23e2b045acba0e402f83d1e1e20496binaries that are unreliablepkgs.foundryfrom nixpkgs (v1.5.1) via a local overlay alias (foundry-bin = prev.foundry)foundryflake input entirelyTest plan
nix-linuxCI job passes (no more foundry download failures)nix-nixosCI job passesnix-darwinCI job passes (was failing with curl 500 onfoundry_nightly_darwin_arm64.tar.gz)foundry-binpackage resolves to nixpkgs foundry 1.5.1🤖 Generated with Claude Code
Summary by cubic
Switch Foundry from
shazow/foundry.nixnightly builds to the stablenixpkgsfoundry(v1.5.1). This stabilizes CI by avoiding unreliable nightly URLs.foundry-bintoprev.foundryvia a local overlay.foundryflake input and its entries fromflake.lock.Written for commit 1707555. Summary will update on new commits.