fix: openclaw client gateway port and pi agents package - #1086
Conversation
- Add :18789 port to openclaw client WSS URL (was missing, defaulting to 443) - Add cagdotin/agents package to pi settings Entire-Checkpoint: c88addb44eab
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical connectivity issue for the Openclaw macOS client by correcting its WSS URL to specify the intended gateway port. Additionally, it enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughTwo configuration files are modified: the OpenClaw hydrate script updates a WebSocket client URL with a port number, and the Pi settings template adds a new package repository URL to the packages array. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mesa DescriptionTL;DRFixes OpenClaw macOS client configuration by adding the correct gateway port to the WSS URL and adds the What changed?
Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Code Review
This pull request addresses two separate issues: it corrects the gateway URL for the OpenClaw client by adding the port, and it adds a new package to the pi settings template. The changes appear correct and align with the PR description. I've added one suggestion to improve the maintainability of the hydrate.sh script by abstracting the hardcoded host and port into variables, which would make future configuration changes easier and less error-prone.
| "remote": { | ||
| "transport": "direct", | ||
| "url": "wss://kyber.tail950b36.ts.net", | ||
| "url": "wss://kyber.tail950b36.ts.net:18789", |
There was a problem hiding this comment.
To improve maintainability and avoid hardcoding values in multiple places, consider defining the gateway host and port as variables at the top of the script.
For example, you could add this near the other configuration variables:
GATEWAY_HOST="kyber.tail950b36.ts.net"
GATEWAY_PORT="18789"Then you can use these variables here. This also allows you to reuse GATEWAY_PORT on line 97 where it's also hardcoded (--port 18789), ensuring consistency.
| "url": "wss://kyber.tail950b36.ts.net:18789", | |
| "url": "wss://${GATEWAY_HOST}:${GATEWAY_PORT}", |
There was a problem hiding this comment.
Pull request overview
Fixes runtime configuration issues so OpenClaw clients connect to the correct gateway port and Pi agents can load an additional package via the settings template.
Changes:
- Update OpenClaw client-mode gateway URL to include the explicit
:18789port for WSS connections. - Add
cagdotin/agentsto the Pi settings templatepackageslist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
config/openclaw/hydrate.sh |
Ensures client-mode remote gateway URL includes the correct port (18789) to avoid defaulting to 443. |
config/pi/settings.tpl.json |
Adds https://github.com/cagdotin/agents to the template’s packages array for Pi agent package installation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Changes
:18789port, causing connections to hit port 443 (WSS default) instead of the actual gateway portcagdotin/agentspackage to pi settings templateTechnical Details
config/openclaw/hydrate.sh: client mode URL changed fromwss://kyber.tail950b36.ts.net→wss://kyber.tail950b36.ts.net:18789config/pi/settings.tpl.json: added second entry topackagesarrayTesting
Summary by cubic
Fixes the OpenClaw client WSS URL to use port :18789 so connections hit the correct gateway instead of defaulting to 443. Adds
cagdotin/agentsto the Pi settings template.Written for commit bbe3188. Summary will update on new commits.