fix(fish): update test files to match renamed function files - #1061
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughFour Fish shell test files are updated to correct function naming references, replacing incorrectly ordered function names with corrected versions across invocations and file sourcing. Two tests also add assertions verifying prompt construction with specific input strings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical CI failures in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRAligns fish spec tests with renamed function files from the abbreviation naming refactor (#1057) to fix CI What changed?
Description generated by Mesa. Update settings |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Follows up on the abbreviation naming refactor (#1057) which renamed _clxte/_clxteh/_clxwe/_clxweh function files but missed updating the corresponding spec/fish test files. Closes the CI failure in fish-test.
882c338 to
6de5ddc
Compare
There was a problem hiding this comment.
Pull request overview
Updates fishtape test files under spec/fish/ to align with the fish function file renames introduced by the abbreviation naming refactor, fixing CI failures caused by stale source paths and old function names.
Changes:
- Rename/replace fishtape test files to match new fish function basenames (
clxteh→cltxeh,clxweh→clwxeh). - Update
sourcepaths and invoked function names inside the affected tests (clxte→cltxe,clxwe→clwxe). - Remove the obsolete test files that referenced the pre-refactor function names.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/fish/_clxweh_function_test.fish | Removed obsolete test file for pre-refactor _clxweh_function. |
| spec/fish/_clxteh_function_test.fish | Removed obsolete test file for pre-refactor _clxteh_function. |
| spec/fish/_clwxeh_function_test.fish | Added test file targeting renamed _clwxeh_function and correct source path. |
| spec/fish/_clwxe_function_test.fish | Updated source path and invoked function name from _clxwe_function to _clwxe_function. |
| spec/fish/_cltxeh_function_test.fish | Added test file targeting renamed _cltxeh_function and correct source path. |
| spec/fish/_cltxe_function_test.fish | Updated source path and invoked function name from _clxte_function to _cltxe_function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the CI failures by updating the test files to reflect the correct function names and source paths. The changes are consistent with the intended renaming of the function files, ensuring that the tests now correctly reference the updated functions. This resolves the "No such file or directory" errors previously encountered in the fish-test CI pipeline.
Summary
spec/fish/_clxte_function_test.fish→_cltxe_function_test.fishspec/fish/_clxteh_function_test.fish→_cltxeh_function_test.fishspec/fish/_clxwe_function_test.fish→_clwxe_function_test.fishspec/fish/_clxweh_function_test.fish→_clwxeh_function_test.fishsourcepaths and function call names in each test fileContext
The abbreviation naming refactor (#1057) renamed the function files in
home-manager/programs/fish/functions/but did not update the corresponding test files inspec/fish/, causing CIfish-testfailures with "No such file or directory" errors.Test plan
fish-testpasses for all four affected test files🤖 Generated with Claude Code
Summary by cubic
Aligns fish spec tests with renamed function files from the abbreviation naming refactor (#1057). Fixes CI
fish-test“No such file or directory” errors._clxte→_cltxe,_clxteh→_cltxeh,_clxwe→_clwxe,_clxweh→_clwxeh.sourcepaths and function calls; interactive flag checks and empty-prompt assertions remain unchanged (rejects and returns 1).Written for commit 6de5ddc. Summary will update on new commits.