Skip to content

fix: rename fish test files to match function renames from #1057 - #1060

Closed
shunkakinoki wants to merge 1 commit into
mainfrom
fix/shellspec-test-filenames
Closed

fix: rename fish test files to match function renames from #1057#1060
shunkakinoki wants to merge 1 commit into
mainfrom
fix/shellspec-test-filenames

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Mar 11, 2026

Copy link
Copy Markdown
Owner

PR #1057 renamed the function files but the corresponding test files weren't renamed, causing shellspec test failures. This PR renames the test files to match the renamed functions.

Renamed files:

  • spec/fish/_clxte_function_test.fish -> spec/fish/_cltxe_function_test.fish
  • spec/fish/_clxteh_function_test.fish -> spec/fish/_cltxeh_function_test.fish
  • spec/fish/_clxwe_function_test.fish -> spec/fish/_clwxe_function_test.fish
  • spec/fish/_clxweh_function_test.fish -> spec/fish/_clwxeh_function_test.fish

This fixes the 4 failing shellspec tests that were checking for test file coverage.


Summary by cubic

Renamed four Fish shell test files to match function renames from #1057. This resolves four failing shellspec tests and restores CI.

Written for commit cd318cf. Summary will update on new commits.

Copilot AI review requested due to automatic review settings March 11, 2026 23:28
@mesa-dot-dev

mesa-dot-dev Bot commented Mar 11, 2026

Copy link
Copy Markdown

You do not have enough credits to review this pull request. Please purchase more credits to continue.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@shunkakinoki has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c1852aa-0a31-49a3-a93c-13dccdca0916

📥 Commits

Reviewing files that changed from the base of the PR and between 4cf3b67 and cd318cf.

📒 Files selected for processing (4)
  • spec/fish/_cltxe_function_test.fish
  • spec/fish/_cltxeh_function_test.fish
  • spec/fish/_clwxe_function_test.fish
  • spec/fish/_clwxeh_function_test.fish
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/shellspec-test-filenames

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses test failures that arose because test file names did not reflect recent changes to function names. By renaming the relevant test files, the PR ensures consistency between function and test file naming conventions, thereby restoring the integrity of the test suite and ensuring all tests pass as expected.

Highlights

Changelog
  • spec/fish/_cltxe_function_test.fish
    • Renamed from spec/fish/_cltxe_test.fish.
  • spec/fish/_cltxeh_function_test.fish
    • Renamed from spec/fish/_cltxeh_test.fish.
  • spec/fish/_clwxe_function_test.fish
    • Renamed from spec/fish/_clwxe_test.fish.
  • spec/fish/_clwxeh_function_test.fish
    • Renamed from spec/fish/_clwxeh_test.fish.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mesa-dot-dev

mesa-dot-dev Bot commented Mar 11, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Renamed fish shellspec test files to match function renames from PR #1057, resolving test failures.

What changed?

  • Renamed spec/fish/_clxte_function_test.fish to spec/fish/_cltxe_function_test.fish
  • Renamed spec/fish/_clxteh_function_test.fish to spec/fish/_cltxeh_function_test.fish
  • Renamed spec/fish/_clxwe_function_test.fish to spec/fish/_clwxe_function_test.fish
  • Renamed spec/fish/_clxweh_function_test.fish to spec/fish/_clwxeh_function_test.fish

Description generated by Mesa. Update settings

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

No code changes or review comments were provided to summarize.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@shunkakinoki
shunkakinoki deleted the fix/shellspec-test-filenames branch March 21, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants