Skip to content

refactor(fish): correct abbreviation naming #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 2 commits into from
Mar 11, 2026
Merged

refactor(fish): correct abbreviation naming #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d710c76
refactor(fish): correct abbreviation naming
shunkakinoki Mar 11, 2026
552b39c
refactor(fish): reorder shell abbreviations for clarity
shunkakinoki Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions home-manager/programs/fish/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,12 @@

# Function-based abbreviations
cliproxyapi = "_cliproxyapi_function";
cltxe = "_cltxe_function";
cltxeh = "_cltxeh_function";
clwxe = "_clwxe_function";
clwxeh = "_clwxeh_function";
Comment on lines 88 to +92

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These abbreviation renames will break the existing fish function tests under spec/fish/*_test.fish, which still source/call the old function names (e.g. _clxwe_function, _clxweh_function, _clxte_function, _clxteh_function). Since CI runs make fish-test (fishtape over spec/fish/*_test.fish) and the coverage spec enforces a spec/fish/${function}_test.fish per function file, the tests need to be renamed/updated to the new _clwxe/_clwxeh/_cltxe/_cltxeh names to keep CI green.

Copilot uses AI. Check for mistakes.
clxe = "_clxe_function";
clxeh = "_clxeh_function";
clxte = "_clxte_function";
clxteh = "_clxteh_function";
clxwe = "_clxwe_function";
clxweh = "_clxweh_function";
coxe = "_coxe_function";
coxeh = "_coxeh_function";
coxel = "_coxel_function";
Expand Down Expand Up @@ -180,12 +180,12 @@
})
[
"_cliproxyapi_function"
"_cltxe_function"
"_cltxeh_function"
"_clwxe_function"
"_clwxeh_function"
"_clxe_function"
"_clxeh_function"
Comment on lines +185 to 188

@gemini-code-assist gemini-code-assist Bot Mar 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and maintainability, this list of function files should be kept in alphabetical order. This block of new functions should be moved before "_clxe_function" on line 183.

"_clxte_function"
"_clxteh_function"
"_clxwe_function"
"_clxweh_function"
"_coxe_function"
"_coxeh_function"
"_coxel_function"
Expand Down
0 ...grams/fish/functions/_clxte_function.fish → ...grams/fish/functions/_cltxe_function.fish
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...rams/fish/functions/_clxteh_function.fish → ...rams/fish/functions/_cltxeh_function.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function _clxteh_function --description "Run Claude Code headlessly with a prompted input with tmux integration"
function _cltxeh_function --description "Run Claude Code headlessly with a prompted input with tmux integration"
# Prompt for input and run Claude Code
# Usage: clxteh
# Usage: cltxeh

read -P "Prompt: " prompt
if test -z "$prompt"
Expand Down
4 changes: 2 additions & 2 deletions ...grams/fish/functions/_clxwe_function.fish → ...grams/fish/functions/_clwxe_function.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function _clxwe_function --description "Run Claude Code with a free-form prompt while skipping permissions with git worktree integration"
function _clwxe_function --description "Run Claude Code with a free-form prompt while skipping permissions with git worktree integration"
# Run Claude Code with a free-form prompt (spaces allowed) and bypass permission checks
# Usage: clxwe [<prompt words...>]
# Usage: clwxe [<prompt words...>]

if test (count $argv) -eq 0
claude --dangerously-skip-permissions --worktree
Expand Down
4 changes: 2 additions & 2 deletions ...rams/fish/functions/_clxweh_function.fish → ...rams/fish/functions/_clwxeh_function.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function _clxweh_function --description "Run Claude Code headlessly with a prompted input with git worktree integration"
function _clwxeh_function --description "Run Claude Code headlessly with a prompted input with git worktree integration"
# Prompt for input and run Claude Code
# Usage: clxweh
# Usage: clwxeh

read -P "Prompt: " prompt
if test -z "$prompt"
Expand Down
Loading