Skip to content

feat(programs): add language servers and php program #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 2 commits into from
Mar 9, 2026
Merged

feat(programs): add language servers and php program #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9343bb9
feat(programs): add language servers and php program
shunkakinoki Mar 9, 2026
a1b6220
fix(programs): use nodejs package name and drop standalone rust-analyzer
shunkakinoki Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions home-manager/programs/bash/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{ lib, pkgs, ... }:
{
home.packages = with pkgs; [
nodePackages.bash-language-server
];

programs.bash = {
enable = true;
enableCompletion = true;
Expand Down
3 changes: 3 additions & 0 deletions home-manager/programs/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ let
lsd = import ./lsd;
neovim = import ./neovim;
node = import ./node;
php = import ./php;
python = import ./python;
rust = import ./rust;
ssh = import ./ssh;
Expand Down Expand Up @@ -53,6 +54,8 @@ in
lazygit
lsd
neovim
node
php
Comment on lines +57 to +58

@gemini-code-assist gemini-code-assist Bot Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, please sort the list of enabled programs alphabetically. While you've added node and php in the correct alphabetical position relative to their neighbors, the entire list is not sorted (e.g., zig appears before starship).

Keeping this list sorted will make it easier to manage as more programs are added. Here is the suggested sorted list:

[
  atuin
  bash
  bat
  btop
  delta
  direnv
  fd
  fish
  fnm
  fzf
  gh
  ghq
  git
  go
  lazydocker
  lazygit
  lsd
  neovim
  node
  php
  python
  rust
  ssh
  starship
  tms
  tmux
  zig
  zoxide
  zsh
]

python
rust
ssh
Expand Down
1 change: 1 addition & 0 deletions home-manager/programs/go/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
{
home.packages = with pkgs; [
go
gopls

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gopls is now installed unconditionally via the Go program module, but it鈥檚 already included in home-manager/packages/default.nix under lib.optionals isDev (lines ~161-167). This creates duplication for dev hosts and also bypasses the existing isDev gating. Consider keeping gopls in only one place (either remove it from the isDev package list or make this module conditional on isDev).

Suggested change
gopls

Copilot uses AI. Check for mistakes.
];
Comment on lines 4 to 6

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description lists added language servers but doesn鈥檛 mention gopls; however this change adds it to the Go program module. Please either update the PR description to include gopls or drop this addition if it鈥檚 out of scope.

Copilot uses AI. Check for mistakes.
}
3 changes: 2 additions & 1 deletion home-manager/programs/node/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ pkgs, ... }:
{
home.packages = with pkgs; [
node
nodejs
nodePackages.typescript-language-server

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodePackages.typescript-language-server is already included in home-manager/packages/default.nix under lib.optionals isDev (lines ~161-167). Adding it here duplicates it on dev hosts and makes it install on non-dev hosts as well (since the programs modules are imported unconditionally). Consider consolidating to a single source of truth or gating this module on isDev.

Suggested change
nodePackages.typescript-language-server

Copilot uses AI. Check for mistakes.
];
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
7 changes: 7 additions & 0 deletions home-manager/programs/php/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{ pkgs, ... }:
{
home.packages = with pkgs; [
php
nodePackages.intelephense
];
}
1 change: 1 addition & 0 deletions home-manager/programs/python/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
home.packages = with pkgs; [
python3
pyright

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyright is already included in home-manager/packages/default.nix under lib.optionals isDev (lines ~161-167). Adding it here duplicates the package on dev hosts and makes it install for non-dev hosts too (since programs/* modules are always imported from home-manager/default.nix). Consider keeping pyright in just one location or making this conditional on isDev.

Suggested change
pyright

Copilot uses AI. Check for mistakes.
];

programs.fish.interactiveShellInit = ''
Expand Down
1 change: 1 addition & 0 deletions home-manager/programs/zig/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
{
home.packages = with pkgs; [
zig
zls
];
}
Loading