Update SKILLS.txt - #90
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughA single entry "max-sixty/worktrunk" is added to SKILLS.txt, expanding the list of skills without any deletions or modifications to existing content. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@SKILLS.txt`:
- Line 13: Replace the unpinned skill entry "max-sixty/worktrunk" in SKILLS.txt
with an immutable GitHub URL that includes a commit SHA or tag (e.g.,
https://github.com/max-sixty/worktrunk/tree/<commit-sha> or /tree/<tag>), update
the Makefile automation (the target that runs `bunx skills add ... --global
--yes`) to stop auto-installing unreviewed skills globally—either require a
pinned URL parameter or remove `--global --yes` and add an explicit confirmation
step—and add a repository policy/check (e.g., CI or CONTRIBUTING note) that
requires a code review for any changes to SKILLS.txt before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| inference-sh/skills | ||
| obra/superpowers | ||
| PaulRBerg/agent-skills | ||
| max-sixty/worktrunk |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Official docs for the skillsCLI: doesskills add support pinning a repository to a tag/commit/SHA (e.g., owner/repo@ref), and what are the recommended security practices for installing third-party skills globally?
💡 Result:
Does skills add support pinning to a tag/commit/SHA (e.g., owner/repo@ref)?
The official skills CLI docs/README do not document an owner/repo@ref syntax for Git refs. The supported “source formats” are owner/repo, full GitHub/GitLab/git URLs, a direct GitHub “tree/…” path, and local paths. [1]
Recommended way to pin anyway: use a GitHub URL that includes the ref in the path, e.g. .../tree/<ref>/... (the README shows tree/main/...; you can replace main with a tag name or a commit SHA on GitHub). [1]
Recommended security practices for installing third-party skills globally
From the official docs:
- Prefer running the CLI via
npx(no global install required). [2] - Use the published Security Audits view as a screening signal. [3]
- Review skills before installing; Vercel notes they can’t guarantee every listed skill is safe and explicitly encourages review and judgment. [4]
- Be cautious with
--globalinstalls (they’re available across all projects); the README documents global scope and that symlinking is the recommended install method. [1]
Sources:
[1] vercel-labs/skills README (source formats, --global, symlink recommendation) (github.com)
[2] Skills CLI docs (npx skills add …, “no installation required”) (skills.sh)
[3] skills.sh Security Audits page (skills.sh)
[4] skills.sh docs (“How are you securing skills?”, “review skills before installing”) (skills.sh)
Citations:
- 1: https://github.com/vercel-labs/skills
- 2: https://skills.sh/docs/cli
- 3: https://skills.sh/audits
- 4: https://skills.sh/docs
Unpinned third-party skill source violates security guidance and introduces supply-chain risk.
Adding max-sixty/worktrunk without an immutable reference exposes the build to unexpected changes. The skills CLI official documentation recommends reviewing every skill before installation and emphasizes that Vercel cannot guarantee each listed skill is safe. This entry is installed globally via Makefile:88-100 (bunx skills add ... --global --yes) with no validation or review step in Makefile:26-33.
Use a pinned GitHub URL (e.g., https://github.com/max-sixty/worktrunk/tree/<commit-sha> or https://github.com/max-sixty/worktrunk/tree/<tag>) instead, add a code review requirement for any new entries in SKILLS.txt, and consider whether the --global --yes automation aligns with your organization's security posture.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@SKILLS.txt` at line 13, Replace the unpinned skill entry
"max-sixty/worktrunk" in SKILLS.txt with an immutable GitHub URL that includes a
commit SHA or tag (e.g.,
https://github.com/max-sixty/worktrunk/tree/<commit-sha> or /tree/<tag>), update
the Makefile automation (the target that runs `bunx skills add ... --global
--yes`) to stop auto-installing unreviewed skills globally—either require a
pinned URL parameter or remove `--global --yes` and add an explicit confirmation
step—and add a repository policy/check (e.g., CI or CONTRIBUTING note) that
requires a code review for any changes to SKILLS.txt before merging.
There was a problem hiding this comment.
Pull request overview
Adds a new skills repository entry to the skills list.
Changes:
- Added
max-sixty/worktrunktoSKILLS.txt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Summary by cubic
Added
max-sixty/worktrunkto SKILLS.txt to include this repository in the skills registry.Written for commit bef2236. Summary will update on new commits.