Skip to content

fix: guard sync target and fix .ruler path separator #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Apr 5, 2026
Merged

fix: guard sync target and fix .ruler path separator #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ SKILLS_FILE := $(dir $(lastword $(MAKEFILE_LIST)))SKILLS.txt
# ROOT TARGETS
# ====================================================================================

ifeq ($(DOTAGENTS_SKIP_SYNC),)
.PHONY: sync
sync: ruler-prepare ## Sync project commands, skills, and MCP configuration to assistant-specific directories.
@make ruler-apply-global
Expand All @@ -38,6 +39,7 @@ sync: ruler-prepare ## Sync project commands, skills, and MCP configuration to a
@make skills-sync
@make mcp-sync
@make ruler-dotdirs-sync
Comment on lines 39 to 41

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These recursive invocations should use $(MAKE) instead of make so flags (e.g., -j jobserver, --no-print-directory, SHELL, etc.) propagate correctly. Suggested change: replace each @make ... with @$(MAKE) ....

Copilot uses AI. Check for mistakes.
endif

Copilot AI Apr 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ifeq ($(DOTAGENTS_SKIP_SYNC),) works, but ifndef DOTAGENTS_SKIP_SYNC is clearer/idiomatic for “run only when unset” and avoids subtle behavior if the variable is set to whitespace. Consider switching to ifndef (optional) to make the intent more immediately readable.

Copilot uses AI. Check for mistakes.

.PHONY: ruler-prepare
ruler-prepare: ## Prepare the project for development.
Expand Down Expand Up @@ -182,7 +184,7 @@ mcp-sync: ## Sync MCP configuration from .ruler/mcp.json to CLI tools.
.PHONY: ruler-apply-global
ruler-apply-global: ruler-prepare ## Apply Ruler outputs to global paths.
@bash -c 'set -e; \
ruler_src="$(abspath $(dir $(lastword $(MAKEFILE_LIST)))).ruler"; \
ruler_src="$(abspath $(dir $(lastword $(MAKEFILE_LIST))))/.ruler"; \
ruler_home="$$HOME/.ruler"; \
rsync -a --delete "$$ruler_src/" "$$ruler_home/"; \
bunx @intellectronica/ruler apply --project-root "$$HOME" --config "$$ruler_home/ruler.toml" --local-only'
Expand Down