Add --timeout notice
#557
Merged
Add --timeout notice
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you want me to change the wording, such as "rounds" vs "trials", or "not recommended for compression algoirthms with fewer rounds" vs "recommended for compression algorithms with many rounds". |
|
Thanks @Winterhuman! We don't actually have zlib with many rounds any more, so the distinction is kinda moot. I'd probably just say that it's currently of limited effectiveness, or similar. |
andrews05
approved these changes
Sep 23, 2023
AlexTMjugador
approved these changes
Sep 25, 2023
Pr0methean
pushed a commit
to Pr0methean/oxipng
that referenced
this pull request
Dec 1, 2023
Closes: shssoichiro#556 Adds a statement saying that `--timeout` isn't as useful for compression algorithms which use fewer and slower rounds, which OxiPNG tends to use nowadays. --------- Co-authored-by: andrews05 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #556
Adds a statement saying that
--timeoutisn't as useful for compression algorithms which use fewer and slower rounds, which OxiPNG tends to use nowadays.