Change validation to a debug assert #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrews05
force-pushed
the
validation
branch
2 times, most recently
from
da687be
to
26034d4
Compare
shssoichiro
force-pushed
the
validation
branch
from
26034d4
to
29a3a03
Compare
|
Oh, removing the test for issue-167 because it's slow? Yes, I'd be fine with that. 😅 |
shssoichiro
approved these changes
Dec 22, 2022
Merged
shssoichiro
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Make dependency on `image` optional After PR #481 was merged, the `image` dependency became unused when building with debug assertions disabled, as it is only used to implement output sanity checks when such assertions are enabled. The `image` crate transitively pulls a significant amount of dependencies, so it's useful for OxiPNG users to get rid of them when not needed. [Cargo does not allow specifying dependencies that are only pulled when debug assertions are enabled](rust-lang/cargo#7634), so the next best way to give users some flexibility is to gate those debug assertions behind a feature flag. These changes add a `sanity-checks` feature flag that controls whether the `image` crate and the related sanity checks are compiled in. This feature is enabled by default to keep debug builds useful to catch problems during development. * Fix Clippy lints * Run tests with new sanity-checks feature enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #478, assuming you're happy to proceed with this :)
As far as I can tell, there's no way to control dependencies or features based on the build profile, which means we have to use debug asserts (either that or restrict it to tests only). It still keeps the release binary smaller though.
P.S. Can we remove issue-167 now? 🤣 (this is the really big one that was only failing because of a bug in the image crate)
Closes #478
Fixes #473