Allow disabling all alpha optimizations when used as a library #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using oxipng as a library, and wanted to disable all alpha optimizations (to be fully lossless). I setting the
alphas
field of theOption
struct to an empty hashset, but I hit an assert in the library.I didn't see any reason why the assert should be there, so I removed the assert, and made the function apply no processing if the hashset was empty. I didn't encounter any problems converting some files (they came out as identical), and
cargo test
passed for me.I've made this pull request just in case this assert is no longer needed. If it's actually there for good reason you can close this pull request.