Switch to standard logging approach #217
Comments
RReverser
added a commit
to RReverser/oxipng
that referenced
this issue
Apr 17, 2020
This allows to configure or compile away logging in the library from a single place in Rust apps. For the CLI side, the usage and output remained the same, except it's now colour-coded. Fixes shssoichiro#217.
shssoichiro
pushed a commit
that referenced
this issue
Apr 18, 2020
This allows to configure or compile away logging in the library from a single place in Rust apps. For the CLI side, the usage and output remained the same, except it's now colour-coded. Fixes #217.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now,
lib.rstakes care of logging by printing all messages toeprintlnwhen configured to do so via ownverbosityoption.It might be better to switch to a standard logging facade compatible with rest of the ecosystem.
This way, users of the library could configure logging from a single place with any logging library of their preference. This would also allow them to configure verbosity from a single place, filter logs based on library, redirect any logs to the desired file, use logger that is specific to some targets like WebAssembly or Android, or even compiling debug logs away to no-op in case they don't want it to be present in the final artifact.
The text was updated successfully, but these errors were encountered: