Skip to content

Commit

Permalink
Improve output for out-of-order processing
Browse files Browse the repository at this point in the history
  • Loading branch information
andrews05 committed Jul 9, 2023
1 parent 09c8bfe commit b804acb
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 6 deletions.
26 changes: 21 additions & 5 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -453,13 +453,15 @@ pub fn optimize(input: &InFile, output: &OutFile, opts: &Options) -> PngResult<(
// Run the optimizer on the decoded PNG.
let mut optimized_output = optimize_png(&mut png, &in_data, opts, deadline)?;

let in_length = in_data.len();

if is_fully_optimized(in_data.len(), optimized_output.len(), opts) {
info!("File already optimized");
match (output, input) {
// if p is None, it also means same as the input path
(OutFile::Path(ref p), InFile::Path(ref input_path))
if p.as_ref().map_or(true, |p| p == input_path) =>
{
info!("{}: Could not optimize further, no change written", input);
return Ok(());
}
_ => {
Expand All @@ -468,8 +470,22 @@ pub fn optimize(input: &InFile, output: &OutFile, opts: &Options) -> PngResult<(
}
}

let savings = if in_length >= optimized_output.len() {
format!(
"{} bytes ({:.2}% smaller)",
optimized_output.len(),
(in_length - optimized_output.len()) as f64 / in_length as f64 * 100_f64
)
} else {
format!(
"{} bytes ({:.2}% larger)",
optimized_output.len(),
(optimized_output.len() - in_length) as f64 / in_length as f64 * 100_f64
)
};

if opts.pretend {
info!("Running in pretend mode, no output");
info!("{}: Running in pretend mode, no output", savings);
return Ok(());
}

Expand Down Expand Up @@ -516,7 +532,7 @@ pub fn optimize(input: &InFile, output: &OutFile, opts: &Options) -> PngResult<(
if let Some(metadata_input) = &opt_metadata_preserved {
copy_times(metadata_input, output_path)?;
}
info!("Output: {}", output_path.display());
info!("{}: {}", savings, output_path.display());
}
}
Ok(())
Expand Down Expand Up @@ -606,14 +622,14 @@ fn optimize_png(
);
}
if file_original_size >= output.len() {
info!(
debug!(
" file size = {} bytes ({} bytes = {:.2}% decrease)",
output.len(),
file_original_size - output.len(),
(file_original_size - output.len()) as f64 / file_original_size as f64 * 100_f64
);
} else {
info!(
debug!(
" file size = {} bytes ({} bytes = {:.2}% increase)",
output.len(),
output.len() - file_original_size,
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ Heuristic filter selection strategies:
// We don't really want to return an error code for those files.
Ok(_) => true,
Err(e) => {
error!("{}", e);
error!("{}: {}", input, e);
false
}
}
Expand Down
1 change: 1 addition & 0 deletions tests/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ fn verbose_mode() {
"Found better combination:",
" zc = 11 f = None ",
" IDAT size = ",
" file size = ",
];
assert_eq!(logs.len(), expected_prefixes.len());
for (i, log) in logs.into_iter().enumerate() {
Expand Down

0 comments on commit b804acb

Please sign in to comment.