Skip to content

Commit

Permalink
Workaround weird regression with &[u8] and zopfli (#595)
Browse files Browse the repository at this point in the history
Fixes #579. In lack of a proper understanding of what's going on here
and why the issue is happening, this workaround will do for now.
  • Loading branch information
andrews05 authored Nov 26, 2024
1 parent f602e84 commit 1936861
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/deflate/zopfli_oxipng.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ pub fn deflate(data: &[u8], iterations: NonZeroU8) -> PngResult<Vec<u8>> {
iteration_count: iterations.into(),
..Default::default()
};
match zopfli::compress(options, zopfli::Format::Zlib, data, &mut output) {
// Since Rust v1.74, passing &[u8] directly into zopfli causes a regression in compressed size
// for some files. Wrapping the slice in another Read implementer such as Box fixes it for now.
match zopfli::compress(options, zopfli::Format::Zlib, Box::new(data), &mut output) {
Ok(_) => (),
Err(_) => return Err(PngError::new("Failed to compress in zopfli")),
};
Expand Down

0 comments on commit 1936861

Please sign in to comment.