Be module-friendly

[efc-awebb]

These classes can be made module-friendly by using a wrapper like this (credit to @sheppard).

(function (factory) {
    if (typeof define === 'function' && define.amd) {
        // AMD
        define(['leaflet'], factory);
    } else if (typeof module !== 'undefined') {
        // Node/CommonJS
        module.exports = factory(require('leaflet'));
    } else {
        // Browser globals
        if (typeof this.L === 'undefined')
            throw 'Leaflet must be loaded first!';
        factory(this.L);
    }
}(function (L) {

L.BingLayer = /* ... */

return L.BingLayer;

}));

This would enable, for example:

var L = require('leaflet');

// Add BingLayer support
var BingLayer = require('./node_modules/leaflet-plugins/layer/tile/Bing');
BingLayer(L);

As it stands, developers writing modular code would have to either monkey-patch that wrapper into place or set up a shim to convert the code into a modular form - neither of which is particularly desirable.

[dmitry]

👍 nice idea!

[johnd0e]

This is mentioned in Leaflet's official PLUGIN-GUIDE.md

[brunob]

I'm on it...

[johnd0e]

But I do not think that mentioned pattern should be put directly into source files.
Better if it'd done in some build process.

[brunob]

We don't have build script and i think this is oversized to use one for that.

[johnd0e]

Well, if you prefer to see same ugly pattern in ~15 source files, instead of simple build script..

[brunob]

Yes, KISS https://en.wikipedia.org/wiki/KISS_principle

[johnd0e]

I like KISS, but not WET.

How about DRY https://en.m.wikipedia.org/wiki/Don't_repeat_yourself?

[brunob]

huhu, sorry but i prefer to keep the release process simple (push a tag & publish to npm).

Anyway, feel free to provide a PR or an issue to describe the build process you would like to use.

[gelinger777]

related to #267

[GhadaAJIMI]

As a user of this pluggin do I have to do this to inclure the rotate function into leaflet ?