Fixes for PlainAdminIntegrationTest#testAlterShareGroupOffsets#228
Merged
fvaleri merged 6 commits intoJul 20, 2026
Merged
Conversation
gaurav-narula
changed the title
fvaleri
previously approved these changes
Jul 17, 2026
fvaleri
left a comment
fvaleri
left a comment
Collaborator
There was a problem hiding this comment.
$ ./gradlew core:test --tests PlaintextAdminIntegrationTest.testDescribeTopicsWithIds
> Configure project :
Starting build with version 4.2.0-SNAPSHOT (commit id e52d05c2) using Gradle 8.14.1, Java 21 and Scala 2.13.16
Build properties: ignoreFailures=false, maxParallelForks=22, maxScalacThreads=8, maxTestRetries=0
> Task :core:test
kafka.api.PlaintextAdminIntegrationTest.testDescribeTopicsWithIds() failed, log available in /home/fvaleri/Documents/kafka/core/build/reports/testOutput/kafka.api.PlaintextAdminIntegrationTest.testDescribeTopicsWithIds().test.stdout
Gradle Test Run :core:test > Gradle Test Executor 171 > PlaintextAdminIntegrationTest > testDescribeTopicsWithIds() FAILED
java.util.concurrent.ExecutionException: java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.apache.kafka.common.requests.MetadataResponse$TopicMetadata.topic()" is null
at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396)
at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073)
at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:155)
at kafka.api.PlaintextAdminIntegrationTest.testDescribeTopicsWithIds(PlaintextAdminIntegrationTest.scala:799)
Caused by:
java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "org.apache.kafka.common.requests.MetadataResponse$TopicMetadata.topic()" is null
at org.apache.kafka.clients.admin.KafkaAdminClient.getTopicDescriptionFromCluster(KafkaAdminClient.java:2521)
at org.apache.kafka.clients.admin.KafkaAdminClient$8.handleResponse(KafkaAdminClient.java:2485)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.handleResponses(KafkaAdminClient.java:1411)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.processRequests(KafkaAdminClient.java:1565)
at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1488)
at java.base/java.lang.Thread.run(Thread.java:1583)
1 test completed, 1 failed
This PR aims at cleaning up the tools module further by getting rid of some extra code which can be replaced by `record` Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
…ader is unavailable (apache#20271) This PR applies the same partition leader check for `StreamsGroupCommand` as `ShareGroupCommand` and `ConsumerGroupCommand` to avoid the command execution timeout. Reviewers: Lucas Brutschy <lucasbru@apache.org>
…hare-groups.sh (apache#20453) The `kafka-share-groups.sh` tool checks whether a topic already has a start-offset in the share group when resetting offsets. This is not necessary. By removing the check, it is possible to set a start offset for a topic which has not yet but will be subscribed in the future, thus initialising the consumption point. There is still a small piece of outstanding work to do with resetting the offset for a non-existent group which should also create the group. A subsequent PR will be used to address that. Reviewers: Jimmy Wang <48462172+JimmyWang6@users.noreply.github.com>, Lan Ding <isDing_L@163.com>, Apoorv Mittal <apoorvmittal10@gmail.com>
…e#20708) This PR allows the kafka-share-groups.sh --reset-offsets tool to be used to set offsets for topics which are not currently subscribed in a share group. It also works if the share group does not yet exist. This brings the capability in line with the equivalent function in Kafka-consumer-groups.sh. The primary purpose is to allow offsets to be set before the share group is first used as a way of initialising in a known state. Reviewers: Jimmy Wang <48462172+JimmyWang6@users.noreply.github.com>, Kuan-Po Tseng <brandboat@gmail.com>, Apoorv Mittal <apoorvmittal10@gmail.com>
gaurav-narula
force-pushed
the
share-group-integration-test-fix
branch
from
July 20, 2026 08:19
e52d05c to
f7e7d4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #161 and #155 and brings in changes from upstream/trunk. The main one is KAFKA-19662 and the proceeding ones are required for the cherry-pick to apply cleanly