Address AS32#205
Merged
Merged
Conversation
The use of StartMirrorTopicsRequestData.TopicData in an external interface looks odd. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Collaborator
Author
|
Also addressing AS33 for convenience: I suggest per-topic error messages in the RPC responses such as PauseMirrorTopics so you can pass back more context, such as the state if the request failed due to a state mismatch. |
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Rename TopicData to TopicMetadata
Owner
|
Let's wait for the CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of StartMirrorTopicsRequestData.TopicData in an external interface looks odd.