Fix describe json output and add offset overwrite IT#202
Merged
Conversation
Owner
Owner
|
UT is failing: |
Fix ClusterMirrorCommand to return [] instead of a text message when --describe --json is used and no mirrors exist. Add integration test to verify that stopping a mirror topic does not cause syncGroupOffsets to overwrite consumer group offsets with stale source values. Refactor AsyncClusterMirrorIntegrationTest to make it faster. We are down from 12 min (cl3) to 2.45 min with one additional test. Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
3 tasks
Collaborator
Author
|
Unit tests looks good locally. BUILD SUCCESSFUL in 11m 13s
249 actionable tasks: 249 executedFailing unit test was marked as flaky: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ClusterMirrorCommand to return [] instead of a text message when --describe --json is used and no mirrors exist. Add integration test to verify that stopping a mirror topic does not cause syncGroupOffsets to overwrite consumer group offsets with stale source values.
Refactor AsyncClusterMirrorIntegrationTest to make it faster. We are down from 12 min (cl3) to 2.45 min with one additional test.