React Native 50 update #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Vladimir-Vdovic, I tried to add your PR to my project and pointed both themes and animations dependencies to your rn-50-update PRs. However, I was not able to get my app running as PropTypes error was presented. Do you have any recommendation on how to get this working? |
Contributor
Author
|
Just use |
dodsky
suggested changes
Dec 8, 2017
| color: bufferColor | ||
| }]; | ||
|
|
||
| if(!NativeModules.BVLinearGradient){ |
Contributor
There was a problem hiding this comment.
Put it on top of the function.
package.json
Outdated
| "lodash": "~4.15.0", | ||
| "qs": "~4.0.0", | ||
| "react-native-lightbox": "shoutem/react-native-lightbox#4e58b9b1aca166142d69b161ff511efc3358ff9f", | ||
| "react-native-lightbox": "shoutem/react-native-lightbox#master", |
Contributor
There was a problem hiding this comment.
Don't point to master directly, add a tag to both repos and point to tag. This might get broken if someone commits to master.
added 2 commits
December 8, 2017 19:01
dodsky
approved these changes
Dec 8, 2017
|
@Vladimir-Vdovic I'm getting resizeMode warnings, is that related to this PR? How to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies for forks and out-of-date packages.
Changed
Imagecomponent to be compatible with RN 0.50.0ImageBackgroundcomponent.Removed obsolete prop
resizeModefromtheme.js.