-
-
Notifications
You must be signed in to change notification settings - Fork 426
Relax missing actual argument expression #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 27 out of 42 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/DocumentationExamples/DocumentationExamples.csproj: Language not supported
- src/Shouldly/Shouldly.csproj: Language not supported
- src/Shouldly.Tests/ConventionTests/IgnoreOnAppVeyorLinuxFact.cs: Evaluated as low risk
- src/Shouldly/Internals/StringHelpers.cs: Evaluated as low risk
- src/Shouldly/ShouldStaticClasses/ShouldThrowTaskAsync.cs: Evaluated as low risk
- README.md: Evaluated as low risk
- src/Shouldly/ShouldlyExtensionMethods/ShouldBe/DateTimeShouldBeTestExtensions.cs: Evaluated as low risk
- src/Shouldly/ShouldStaticClasses/ShouldCompleteInExtensions.cs: Evaluated as low risk
- src/Shouldly/ShouldStaticClasses/DynamicShould.cs: Evaluated as low risk
- src/Shouldly/ShouldlyExtensionMethods/ShouldBe/NumericShouldBeTestExtensions.cs: Evaluated as low risk
- src/Shouldly.Tests/ConventionTests/ApprovePublicApi.cs: Evaluated as low risk
- src/Shouldly/ShouldStaticClasses/ShouldThrowTask.cs: Evaluated as low risk
- src/Shouldly/ShouldStaticClasses/ShouldThrow.cs: Evaluated as low risk
- src/DocumentationExamples/ShouldMatchApprovedExamples.cs: Evaluated as low risk
- src/Shouldly.Tests/ConventionTests/ShouldlyConventions.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Shouldly/Internals/SourceCodeTextGetter.cs:58
- The
_determinedOriginatingFrameassignment should be handled correctly to ensure it is only set if the file exists. Consider adding a check to handle this.
_determinedOriginatingFrame = fileName != null && File.Exists(fileName);
1 task
This was referenced Aug 25, 2025
This was referenced Sep 1, 2025
This was referenced Sep 10, 2025
This was referenced Sep 18, 2025
This was referenced Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to self, do smaller commits!
This is a few changes:
NoInline, our stack walking works. I've tested this using a release mode test app, and running assertions in a tight loop, this causes a reJIT where theShouldBe...method gets inlined. This is a new feature in .NET 7 where methods across assembly boundaries can be inlined by the Dynamic PGO.[EditorBrowsable(EditorBrowsableState.Never)]to extension classes, to keep them from cluttering user intellisense.