Skip to content

Update deps#671

Merged
conorbros merged 3 commits intoshotover:mainfrom
rukai:update_deps
Jun 10, 2022
Merged

Update deps#671
conorbros merged 3 commits intoshotover:mainfrom
rukai:update_deps

Conversation

@rukai
Copy link
Copy Markdown
Contributor

@rukai rukai commented Jun 8, 2022

metrics::clear_recorder(); was removed from metrics (technically just marked unsafe and hidden from docs) due to being dangerous to use.
So I changed our metrics init code to instead ignore errors due to metrics already being initialized.

@rukai rukai requested a review from conorbros June 9, 2022 07:17
@rukai
Copy link
Copy Markdown
Contributor Author

rukai commented Jun 9, 2022

@conorbros would be good to rereview this considering there was a drastic change since your previous approval.

@conorbros conorbros enabled auto-merge (squash) June 9, 2022 23:57
@conorbros conorbros merged commit 1bf9c34 into shotover:main Jun 10, 2022
@github-actions
Copy link
Copy Markdown

1 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/2471802550

�[2m2022-06-10T00:23:00.243025Z�[0m �[31mERROR�[0m �[2mshotover_proxy::server�[0m�[2m:�[0m source CassandraSource encountered an error when flushing the chain for shutdown: Connection refused (os error 111)
cassandra/tls_insert    time:   [1.0291 ms 1.0593 ms 1.0929 ms]
                        thrpt:  [915.02  elem/s 944.00  elem/s 971.74  elem/s]
                 change:
                        time:   [+25.046% +33.845% +42.780%] (p = 0.00 < 0.05)
                        thrpt:  [-29.962% -25.287% -20.030%]
                        Performance has regressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants