Skip to content

Conversation

@rukai
Copy link
Member

@rukai rukai commented Feb 26, 2024

Simplifies the implementation of our configuration webservers and removes the duplicate hyper dependency.

Currently this PR regresses release build time by 9s on my machine.
I thought we might win back some build time by the removal of hyper 0.14 but in this measurement of 9s I have already removed hyper 0.14

Not sure if its worth proceeding with this cost to build time.

@rukai rukai force-pushed the axum branch 2 times, most recently from 2047442 to 9a36f91 Compare February 27, 2024 22:44
@rukai rukai force-pushed the axum branch 2 times, most recently from 70c76bd to 95b1d9e Compare March 13, 2024 04:03
@rukai rukai marked this pull request as ready for review March 13, 2024 04:36
@rukai
Copy link
Member Author

rukai commented Mar 13, 2024

I've thought about it and I think we should just go ahead with this.
We dont want to be stuck on an unmaintained version of hyper.
And the swap to axum makes our http servers simpler, more robust and more easily extensible for any future runtime configuration needs.
So i think that for now its worth the additional 9s on release builds.

We should however be on the lookout for an http server of similar quality and ease of use as axum, but something a bit simpler since we dont need the most flexible http server.
If we find such a crate we can always swap to it in the future.

@rukai rukai requested a review from conorbros March 13, 2024 04:42
@conorbros conorbros enabled auto-merge (squash) March 14, 2024 10:52
@rukai
Copy link
Member Author

rukai commented Mar 17, 2024

hyperium/hyper-util#110 Someone created an example demonstrate using hyper 1.0 as a server, might be worth trying it out before landing this.
The design in #1529 would benefit greatly from a proper webserver, so lets go ahead with this.

@conorbros conorbros merged commit 7fdc43e into shotover:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants