Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code_push_client): track version #646

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

felangel
Copy link
Contributor

Description

  • feat(code_push_client): track version

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel requested review from eseidel and bryanoltman June 13, 2023 21:05
@felangel felangel self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.73 ⚠️

Comparison is base (57ad26b) 100.00% compared to head (1de5a81) 97.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #646      +/-   ##
===========================================
- Coverage   100.00%   97.27%   -2.73%     
===========================================
  Files            5      149     +144     
  Lines          173     3592    +3419     
===========================================
+ Hits           173     3494    +3321     
- Misses           0       98      +98     

see 144 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felangel
Copy link
Contributor Author

Codecov Report

Patch coverage has no change and project coverage change: -2.73 ⚠️

Comparison is base (57ad26b) 100.00% compared to head (1de5a81) 97.27%.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Do you have feedback about the report comment? Let us know in this issue.

This is complaining about cutler

@felangel felangel merged commit 51849f5 into main Jun 13, 2023
@felangel felangel deleted the feat/code-push-client-track-version branch June 13, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants