Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/shorebird_cli/lib/src/executables/powershell.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ class Powershell {

final result = await pwsh(['-Command', pwshCommand]);

var versionString = (result.stdout as String).trim();
if (!versionString.contains('+')) {
versionString += '+0';
}
return versionString;
return (result.stdout as String).trim();
Comment thread
felangel marked this conversation as resolved.
}
}
2 changes: 1 addition & 1 deletion packages/shorebird_cli/lib/src/platform/windows.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ import 'package:pub_semver/pub_semver.dart';
const primaryWindowsReleaseArtifactArch = 'win_archive';

/// The minimum allowed Flutter version for creating Windows releases.
final minimumSupportedWindowsFlutterVersion = Version(3, 27, 2);
final minimumSupportedWindowsFlutterVersion = Version(3, 32, 6);
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ void main() {
});

group('minimumFlutterVersion', () {
test('is 3.27.2', () {
expect(releaser.minimumFlutterVersion, Version(3, 27, 2));
test('is 3.32.6', () {
expect(releaser.minimumFlutterVersion, Version(3, 32, 6));
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ void main() {
});

test(
'returns the version string with build number 0 added',
'returns the version string without a build number',
() async {
final version = await runWithOverrides(
() => powershell.getExeVersionString(File('')),
);
expect(version, '1.0.0+0');
expect(version, '1.0.0');
},
);
});
Expand Down
Loading