Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding better debugging logging for aot tools link #2166

Merged
merged 5 commits into from
May 29, 2024

Conversation

erickzanardo
Copy link
Contributor

Description

Shorebird CLI calls aot_tools link, which stores its logging data in a temporary folder. When the link command finishes, the CLI will consolidate everything in that temp folder in a single zip file.

But if that command hangs, the consolidation will never happen, making it virtually impossible to recover those files.

This PR adds a debug log, which will print the path for the temporary debug info folder, which, by using the -v flag, will allow us to check on those debug files when we get in a situation described above.

This PR is an effort in the investigation of #2160

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.41%. Comparing base (af744d2) to head (54d53b6).

Files Patch % Lines
...rebird_cli/lib/src/commands/patch/ios_patcher.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #2166      +/-   ##
===========================================
- Coverage   100.00%   90.41%   -9.59%     
===========================================
  Files          184      184              
  Lines         5653     5657       +4     
===========================================
- Hits          5653     5115     -538     
- Misses           0      542     +542     
Flag Coverage Δ
shorebird_cli 87.69% <0.00%> (-12.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erickzanardo erickzanardo enabled auto-merge (squash) May 29, 2024 19:38
@erickzanardo erickzanardo merged commit 6aa88e3 into main May 29, 2024
9 of 11 checks passed
@erickzanardo erickzanardo deleted the feat/adding-debug-logging-for-link branch May 29, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants