Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shorebird_cli): ensure flutter artifacts are installed in shorebird preview #1812

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix(shorebird_cli): ensure flutter artifacts are installed in shorebird preview #1812

merged 1 commit into from
Mar 22, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Updates the shorebird preview command to run flutter precache to ensure artifacts required to preview have been downloaded.

Fixes #1795

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel March 22, 2024 18:01
@bryanoltman bryanoltman merged commit e159584 into main Mar 22, 2024
6 checks passed
@bryanoltman bryanoltman deleted the bo/preview-install-ios-deploy branch March 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: shorebird preview for iOS fails if no Flutter commands have previously run
2 participants
@bryanoltman @felangel