Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(googleapis_auth): rename AuthProvider to AuthEndpoints #1755

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

A future PR is going to introduce an AuthProvider enum. Because the googleapis_auth AuthProvider is just a pair of endpoints, call it AuthEndpoints to reduce confusion.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (67a06e7) to head (3a18fa0).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1755   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          165       165           
  Lines         5136      5136           
=========================================
  Hits          5136      5136           
Flag Coverage Δ
googleapis_auth ∅ <ø> (∅)
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman requested a review from felangel February 26, 2024 19:41
@bryanoltman bryanoltman merged commit a330d52 into main Feb 26, 2024
9 checks passed
@bryanoltman bryanoltman deleted the bo/auth-endpoints branch February 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants