Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): remove --channel option from patch and preview commands #1342

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Oct 2, 2023

Description

  • chore(shorebird_cli): remove --channel option from patch and preview commands
    • based on internal discussion going to simplify the approach even further and abstract the concept of channels.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a975dd6) 100.00% compared to head (cd8ccac) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1342   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         4724      4718    -6     
=========================================
- Hits          4724      4718    -6     
Flag Coverage Δ
shorebird_cli 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../lib/src/commands/patch/patch_android_command.dart 100.00% <ø> (ø)
..._cli/lib/src/commands/patch/patch_ios_command.dart 100.00% <ø> (ø)
...horebird_cli/lib/src/commands/preview_command.dart 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 1aa7ecf into main Oct 2, 2023
@felangel felangel deleted the chore/shorebird-cli-remove-channel-option branch October 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants