Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code_push_client): revert client version bump #1260

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

felangel
Copy link
Contributor

Description

  • chore(code_push_client): revert client version bump
    • since this wasn't being used by the CLI it's not a breaking change and doesn't require a force upgrade

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c826819) 98.93% compared to head (102eca4) 98.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files         179      179           
  Lines        4620     4620           
=======================================
  Hits         4571     4571           
  Misses         49       49           
Flag Coverage Δ
shorebird_cli 100.00% <ø> (ø)
shorebird_code_push_client 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit 4a42ac6 into main Sep 12, 2023
@felangel felangel deleted the chore/revert-client-version-bump branch September 12, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants