Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shorebird_cli): update powershell script to exit on errors #1060

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix(shorebird_cli): update powershell script to exit on errors #1060

merged 1 commit into from
Aug 8, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Use ErrorActionPreference to respond to errors by stopping script execution.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@felangel felangel merged commit 00da93e into main Aug 8, 2023
@felangel felangel deleted the bo/windows-error-exit branch August 8, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

@kmillikin kmillikin Awaiting requested review from kmillikin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanoltman @felangel