Skip to content

Commit

Permalink
fix(shorebird_cli): don't check for new flutter versions after build (#…
Browse files Browse the repository at this point in the history 
…1135)
  • Loading branch information
@bryanoltman
bryanoltman authored Aug 21, 2023
1 parent 96676c8 commit 64f6ca6
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 25 deletions.
2 changes: 1 addition & 1 deletion packages/shorebird_cli/lib/src/shorebird_build_mixin.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ mixin ShorebirdBuildMixin on ShorebirdCommand {
/// https://github.com/shorebirdtech/shorebird/issues/1101 for more info.
Future<void> _systemFlutterPubGet() async {
const executable = 'flutter';
final arguments = ['pub', 'get', '--offline'];
final arguments = ['--no-version-check', 'pub', 'get', '--offline'];

final result = await process.run(
executable,
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/build/build_aar_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -204,7 +204,7 @@ ${lightCyan.wrap(
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/build/build_apk_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -190,7 +190,7 @@ ${lightCyan.wrap(p.join('build', 'app', 'outputs', 'apk', 'release', 'app-releas
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/build/build_app_bundle_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -267,7 +267,7 @@ ${lightCyan.wrap(p.join('build', 'app', 'outputs', 'bundle', '${flavor}Release',
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/build/build_ipa_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -204,7 +204,7 @@ ${lightCyan.wrap(p.join('build', 'ios', 'ipa', 'Runner.ipa'))}''',
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/patch/patch_aar_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -833,7 +833,7 @@ Please re-run the release command for this version or create a new release.'''),
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/patch/patch_android_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ flutter:
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -776,7 +776,7 @@ Or change your Flutter version and try again using:
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/patch/patch_ios_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ flutter:
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -810,7 +810,7 @@ Or change your Flutter version and try again using:
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/patch/patch_ios_framework_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ flutter:
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -742,7 +742,7 @@ Please re-run the release command for this version or create a new release.'''),
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/release/release_aar_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -410,7 +410,7 @@ void main() {
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/release/release_android_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ void main() {
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -445,7 +445,7 @@ void main() {
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/release/release_ios_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ flutter:
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -531,7 +531,7 @@ error: exportArchive: No signing certificate "iOS Distribution" found
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down
4 changes: 2 additions & 2 deletions packages/shorebird_cli/test/src/commands/release/release_ios_framework_command_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ flutter:
when(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down Expand Up @@ -399,7 +399,7 @@ flutter:
verify(
() => shorebirdProcess.run(
'flutter',
['pub', 'get', '--offline'],
['--no-version-check', 'pub', 'get', '--offline'],
runInShell: any(named: 'runInShell'),
useVendedFlutter: false,
),
Expand Down

0 comments on commit 64f6ca6

Please sign in to comment.