Skip to content

Commit

Permalink
fix: update iOS warning to say "beta" and only show on patching. (#1679)
Browse files Browse the repository at this point in the history
  • Loading branch information
eseidel authored Jan 31, 2024
1 parent 22b389b commit 0a6e2ac
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 10 deletions.
6 changes: 6 additions & 0 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

This section contains past updates we've sent to customers via Discord.

## 0.24.1 (January 31, 2024)

* iOS release builds now run at full speed. iOS patches remain slower than releases.

📚 Release notes can be found at https://github.com/shorebirdtech/shorebird/releases/tag/v0.24.1

## 0.24.0 (January 30, 2024)

This is our last planned release before iOS beta. We believe iOS is stable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import 'package:shorebird_cli/src/command.dart';
import 'package:shorebird_cli/src/config/config.dart';
import 'package:shorebird_cli/src/doctor.dart';
import 'package:shorebird_cli/src/extensions/arg_results.dart';
import 'package:shorebird_cli/src/ios.dart';
import 'package:shorebird_cli/src/logger.dart';
import 'package:shorebird_cli/src/shorebird_artifact_mixin.dart';
import 'package:shorebird_cli/src/shorebird_build_mixin.dart';
Expand Down Expand Up @@ -120,8 +119,6 @@ make smaller updates to your app.
return e.exitCode.code;
}

showiOSStatusWarning();

final codesign = results['codesign'] == true;
if (!codesign) {
logger
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:shorebird_cli/src/code_push_client_wrapper.dart';
import 'package:shorebird_cli/src/command.dart';
import 'package:shorebird_cli/src/config/config.dart';
import 'package:shorebird_cli/src/doctor.dart';
import 'package:shorebird_cli/src/ios.dart';
import 'package:shorebird_cli/src/logger.dart';
import 'package:shorebird_cli/src/shorebird_artifact_mixin.dart';
import 'package:shorebird_cli/src/shorebird_build_mixin.dart';
Expand Down Expand Up @@ -53,8 +52,6 @@ of the iOS app that is using this module.''',
return e.exitCode.code;
}

showiOSStatusWarning();

const releasePlatform = ReleasePlatform.ios;
final releaseVersion = results['release-version'] as String;
final shorebirdYaml = shorebirdEnv.getShorebirdYaml()!;
Expand Down
6 changes: 4 additions & 2 deletions packages/shorebird_cli/lib/src/ios.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import 'package:shorebird_cli/src/logger.dart';

void showiOSStatusWarning() {
final url = link(
uri: Uri.parse('https://docs.shorebird.dev/status#ios-alpha'),
uri: Uri.parse('https://docs.shorebird.dev/status'),
);
logger.warn('iOS support is alpha. See $url for more information.');
logger
..warn('iOS support is beta. Some apps may run slower after patching.')
..info('See $url for more information.');
}
2 changes: 1 addition & 1 deletion packages/shorebird_cli/lib/src/version.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/shorebird_cli/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: shorebird_cli
description: Command-line tool to interact with Shorebird's services.
version: 0.24.0
version: 0.24.1
repository: https://github.com/shorebirdtech/shorebird

publish_to: none
Expand Down

0 comments on commit 0a6e2ac

Please sign in to comment.