chore: update to use new CreateGroupIsolate API #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I need to update our engine version on shorebird/dev before this can work, sec. |
eseidel
force-pushed
the
shorebird/dev
branch
from
4a474de to
142559d
Compare
Author
|
There doesn't seem to be a good way to get shorebird_ci to pass when we're making a new build of hte engine, since definitionally, we don't have an engine build to offer yet. I could send this commit to be an engine build (especially if I squashed it down), but then I would just need to build again once I land it, so I'm just going to land it and build there (since the hash will change when I do). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.