chore: roll dart to f948325f66c85980c3d4ebdf8da18a399195003f #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. (flutter#160798) Closes flutter#160592. ~Made a few other tiny non-breaking refactors, for example changing `withValues` internally.~
Additionally: - Deprecation message analyzer: use AST more instead of regex - Deprecation message analyzer: removes some tests since they are in the formatter's jurisdiction now - update the analyzer test fixture to fix a couple line numbers - `@_debugOnly` set `multiline` back to false. The source we get back from the `ASTNode` doesn't have any line feed characters. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…iOS devices (flutter#160484) Work towards flutter#143299. Work towards flutter#160043. --- This PR implements, end-to-end, support for `matchesGoldenFile` when (a) running with `package:integration_test` (b) on a device, such as an Android emulator, Android device, iOS simulator, or iOS device, where the _runner_ of a test file does not have process and local-file system access. There are multiple parts to this PR; I could make it smaller than 1K lines, but the bulk of that is tests, and it would mean landing PRs that are incomplete and unused, which does not seem useful - so instead here is a quick overview of the PR's contents - questions/feedback welcome, and I am willing to break code out or land incremental refactors if requested. 1. Augmented `flutter_platform.dart` (used for iOS and Android), similar to [`flutter_web_platform.dart`](https://github.com/flutter/flutter/blob/1398dc7eecb696d302e4edb19ad79901e615ed56/packages/flutter_tools/lib/src/test/flutter_web_platform.dart#L117-L128), now creates and uses [`test_golden_comparator.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/test/test_golden_comparator.dart) to proxy calls (coming from the VM service protocol) for golden-file updates and comparisons to a `flutter_tester` process. A full explanation of how (or why) it works this way is too hard to include here, but see flutter#160215 for more details. 1. Added `VmServiceProxyGoldenFileComparator`, which is a currently unused (outside of a single e2e test) comparator that forwards calls to `compare` and `update` to the VM service protocol (of which, the other side of this is implemented above, in `flutter_platform.dart`. The idea is that this comparator would be used automatically when running in an integration test on a device that requires it (similar to how web works today), but that is **not** wired up yet and requires additional work in `flutter_tools`. 1. Added two unit tests (of both the client and server), and a full e2e-test using it to run `matchesGoldenFile`.
Point to real Cocoon code in Tree-hygiene.md Co-authored-by: Matan Lurey <[email protected]>
Resolves flutter#160402 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Work towards flutter#150800
…s`." (flutter#160980) Reverts flutter#160380; this ended up not being needed. Closes flutter#160379.
…ithub-actions group (flutter#161001) Bumps the all-github-actions group with 1 update: [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `peter-evans/create-pull-request` from 7.0.5 to 7.0.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>Create Pull Request v7.0.6</h2> <p>⚙️ Fixes an issue with commit signing where unicode characters in file paths were not preserved.</p> <h2>What's Changed</h2> <ul> <li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.38.1 to 0.38.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3365">peter-evans/create-pull-request#3365</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3370">peter-evans/create-pull-request#3370</a></li> <li>build(deps): bump <code>@octokit/plugin-rest-endpoint-methods</code> from 13.2.4 to 13.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3375">peter-evans/create-pull-request#3375</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.50 to 18.19.54 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3376">peter-evans/create-pull-request#3376</a></li> <li>build(deps): bump <code>@octokit/plugin-paginate-rest</code> from 11.3.3 to 11.3.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3377">peter-evans/create-pull-request#3377</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3388">peter-evans/create-pull-request#3388</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.54 to 18.19.55 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3400">peter-evans/create-pull-request#3400</a></li> <li>build(deps): bump <code>@actions/core</code> from 1.10.1 to 1.11.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3401">peter-evans/create-pull-request#3401</a></li> <li>build(deps): bump <code>@octokit/plugin-rest-endpoint-methods</code> from 13.2.5 to 13.2.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3403">peter-evans/create-pull-request#3403</a></li> <li>build(deps-dev): bump eslint-plugin-import from 2.30.0 to 2.31.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3402">peter-evans/create-pull-request#3402</a></li> <li>build(deps): bump <code>@octokit/plugin-throttling</code> from 9.3.1 to 9.3.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3404">peter-evans/create-pull-request#3404</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3423">peter-evans/create-pull-request#3423</a></li> <li>build(deps-dev): bump typescript from 5.6.2 to 5.6.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3441">peter-evans/create-pull-request#3441</a></li> <li>build(deps): bump undici from 6.19.8 to 6.20.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3442">peter-evans/create-pull-request#3442</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3451">peter-evans/create-pull-request#3451</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.55 to 18.19.58 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3457">peter-evans/create-pull-request#3457</a></li> <li>build(deps-dev): bump <code>@types/jest</code> from 29.5.13 to 29.5.14 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3462">peter-evans/create-pull-request#3462</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.58 to 18.19.60 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3463">peter-evans/create-pull-request#3463</a></li> <li>chore: don't bundle undici by <a href="https://github.com/benmccann"><code>@benmccann</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3475">peter-evans/create-pull-request#3475</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3478">peter-evans/create-pull-request#3478</a></li> <li>chore: use node-fetch-native support for proxy env vars by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3483">peter-evans/create-pull-request#3483</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.60 to 18.19.64 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3488">peter-evans/create-pull-request#3488</a></li> <li>build(deps-dev): bump undici from 6.20.1 to 6.21.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3499">peter-evans/create-pull-request#3499</a></li> <li>build(deps-dev): bump <code>@vercel/ncc</code> from 0.38.2 to 0.38.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3500">peter-evans/create-pull-request#3500</a></li> <li>docs: note <code>push-to-repo</code> classic PAT <code>workflow</code> scope requirement by <a href="https://github.com/scop"><code>@scop</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3511">peter-evans/create-pull-request#3511</a></li> <li>docs: spelling fixes by <a href="https://github.com/scop"><code>@scop</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3512">peter-evans/create-pull-request#3512</a></li> <li>build(deps-dev): bump typescript from 5.6.3 to 5.7.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3516">peter-evans/create-pull-request#3516</a></li> <li>build(deps-dev): bump prettier from 3.3.3 to 3.4.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3517">peter-evans/create-pull-request#3517</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.64 to 18.19.66 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3518">peter-evans/create-pull-request#3518</a></li> <li>docs(README): clarify that an existing open PR is managed by <a href="https://github.com/caugner"><code>@caugner</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3498">peter-evans/create-pull-request#3498</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3529">peter-evans/create-pull-request#3529</a></li> <li>build(deps): bump <code>@octokit/plugin-paginate-rest</code> from 11.3.5 to 11.3.6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3542">peter-evans/create-pull-request#3542</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.66 to 18.19.67 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3543">peter-evans/create-pull-request#3543</a></li> <li>build(deps-dev): bump prettier from 3.4.0 to 3.4.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3544">peter-evans/create-pull-request#3544</a></li> <li>build(deps-dev): bump eslint-import-resolver-typescript from 3.6.3 to 3.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3559">peter-evans/create-pull-request#3559</a></li> <li>build(deps-dev): bump prettier from 3.4.1 to 3.4.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3560">peter-evans/create-pull-request#3560</a></li> <li>build(deps-dev): bump <code>@types/node</code> from 18.19.67 to 18.19.68 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3570">peter-evans/create-pull-request#3570</a></li> <li>build(deps): bump p-limit from 6.1.0 to 6.2.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3578">peter-evans/create-pull-request#3578</a></li> <li>Update distribution by <a href="https://github.com/actions-bot"><code>@actions-bot</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3583">peter-evans/create-pull-request#3583</a></li> <li>fix: preserve unicode in filepaths when commit signing by <a href="https://github.com/peter-evans"><code>@peter-evans</code></a> in <a href="https://github.com/peter-evans/create-pull-request/pull/3588">peter-evans/create-pull-request#3588</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/benmccann"><code>@benmccann</code></a> made their first contribution in <a href="https://github.com/peter-evans/create-pull-request/pull/3475">peter-evans/create-pull-request#3475</a></li> <li><a href="https://github.com/scop"><code>@scop</code></a> made their first contribution in <a href="https://github.com/peter-evans/create-pull-request/pull/3511">peter-evans/create-pull-request#3511</a></li> <li><a href="https://github.com/caugner"><code>@caugner</code></a> made their first contribution in <a href="https://github.com/peter-evans/create-pull-request/pull/3498">peter-evans/create-pull-request#3498</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/peter-evans/create-pull-request/commit/67ccf781d68cd99b580ae25a5c18a1cc84ffff1f"><code>67ccf78</code></a> fix: preserve unicode in filepaths when commit signing (<a href="https://github.com/peter-evans/create-pull-request/issues/3588">#3588</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/bb88e27d3f9cc69c8bc689eba126096c6fe3dded"><code>bb88e27</code></a> build: update distribution (<a href="https://github.com/peter-evans/create-pull-request/issues/3583">#3583</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/b378ed537a3374cbb7642141277ace10488f9318"><code>b378ed5</code></a> build(deps): bump p-limit from 6.1.0 to 6.2.0 (<a href="https://github.com/peter-evans/create-pull-request/issues/3578">#3578</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/fa9200e5b4f0d3fe4adc6d4a980fdb27ca333ed2"><code>fa9200e</code></a> build(deps-dev): bump <code>@types/node</code> from 18.19.67 to 18.19.68 (<a href="https://github.com/peter-evans/create-pull-request/issues/3570">#3570</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/16e0059bfd236716f0191bfcfa63d9ded4cf325f"><code>16e0059</code></a> build(deps-dev): bump prettier from 3.4.1 to 3.4.2 (<a href="https://github.com/peter-evans/create-pull-request/issues/3560">#3560</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/5bffd5ae80c9e3cdce3fdaba74ba437193643add"><code>5bffd5a</code></a> build(deps-dev): bump eslint-import-resolver-typescript (<a href="https://github.com/peter-evans/create-pull-request/issues/3559">#3559</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/a22a0ddc2127a4161a9f144623d1e51be98d81aa"><code>a22a0dd</code></a> build(deps-dev): bump prettier from 3.4.0 to 3.4.1 (<a href="https://github.com/peter-evans/create-pull-request/issues/3544">#3544</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/b27ce378c8a71596550fb729c05c9a998f8ff26f"><code>b27ce37</code></a> build(deps-dev): bump <code>@types/node</code> from 18.19.66 to 18.19.67 (<a href="https://github.com/peter-evans/create-pull-request/issues/3543">#3543</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/4e0cc19e22f9071762b3542aa9fa90a1d682dd32"><code>4e0cc19</code></a> build(deps): bump <code>@octokit/plugin-paginate-rest</code> from 11.3.5 to 11.3.6 (<a href="https://github.com/peter-evans/create-pull-request/issues/3542">#3542</a>)</li> <li><a href="https://github.com/peter-evans/create-pull-request/commit/25b6871a4ebe4c3585f47c7a687ac6fd0ec0e32d"><code>25b6871</code></a> docs: update scopes for push-to-fork</li> <li>Additional commits viewable in <a href="https://github.com/peter-evans/create-pull-request/compare/5e914681df9dc83aa4e4905692ca88beb2f9e91f...67ccf781d68cd99b580ae25a5c18a1cc84ffff1f">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Since the autoroller is currently disabled (due to flutter#160473) this does a manual roll of our dependencies to ensure that we don't fall too far behind.
This PR rolls in a number of breaking changes from dart-lang/native: * `BuildMode` is no longer part of the protocol, so Flutter no longer passes it in. * This means all code dealing with the name conflict between `native_assets_cli.BuildMode` and `flutter_tools.BuildMode` has been cleaned up. * Also, the logs no longer mention the build mode. * The tests still exercise both modes, because linking only happens in release mode. * `OS` is no longer part of the main protocol, but of the "code" "protocol extension". * The code now aligns more with `OS?` being nullable in a bunch of places, since it is nullable if there's no code assets. * The OS-specific config is nested in an object per OS. * `CCompilerConfig`s fields are non-nullable now. * So instead of passing an object with nullable fields around, a null instead of the object is returned in various places. * `FileSystem` is now passed in to the native assets builder. This PR contains no feature changes. This PR will need to be followed up by restricting what environment variables are passed in (similar to dart-lang/native#1764), I will do this in a follow up PR. Tests: * All existing features should be covered by existing tests.
Follow-up to flutter#160985. These were missed by `flutter update-packages --force-upgrade` in flutter#160985, likely due to some circular dependency issue. They've been bumped by hand in this PR.
…ocal-web-sdk` (flutter#161110) Now that we're in a monorepo, it makes sense to use the in-tree engine by default when using `--local-engine` or `--local-web-sdk` rather than looking for a sibling directory like we used to.
Follow up of flutter#160672 to filter the environment keys being passed in to build hooks. ~~Failures don't reproduce locally, so this is a draft PR to see which environment keys are needed for the tests to succeed on CI.~~ Edit: Fixed issues by stopping to use the Flutter-self-update-dart-executable and instead using the Dart-sdk-dart-executable. Relevant bug (already addressed in Dart standalone). * dart-lang/native#32 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…160982) Closes flutter#160219. This hard-coded package configuration is no longer strictly correct as-of Dart 3.6.0; a pub _workspace_ (https://dart.dev/tools/pub/workspaces) can appear at a higher-level than a package, and if the package is part of the workspace, tooling is expected to (automatically) find `.dart_tool/package_config.json` at a higher-level. For example, the _engine_ sub-repo uses a [workspace](https://github.com/flutter/flutter/blob/9fd5bddc65c3616a5a0ba9af44e1bd7fe8c99c1d/engine/src/flutter/pubspec.yaml#L82), which means that, for example, `%ENGINE%/tools/engine_tool/.dart_tool/package_config.json` will _never_ exist (it will be at `%ENGINE%/.dart_tools/package_config.json`. As currently defined, the test-golden comparator interface will fail with a package that uses workspaces. By removing the flag (and letting automatic `--packages` resolution occur), I _believe_ the problem is automatically resolved (but I'll let CI prove that for us).
…efs (flutter#161067) - rev to the latest dart-lang/http and remove older refs to dart-lang/http_multi_server This updates the combined flutter+engine repo to account for upstream repo merges (package:http_multi_server ==> dart-lang/http). Main tracking issue: - dart-lang/sdk#56591 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…`. (flutter#160937) Closes flutter#160933. The timing of this callback gives our users (and plugin authors) a chance to stop using the `Surface` before it becomes invalid, allowing us to fix flutter#156488 - we no longer need to do shenanigans on storing and restoring state because `ExoPlayer` can now handle it out of the box; see flutter#160933 (comment). It's unfortunate we have to go through a bit of churn on the callback API, but realistically this _is_ the feedback we were looking for when originally creating it - it just took longer than expected due to the long release cycle. /cc @hasali19, @xxoo, @camsim99
Post-submit feedback from flutter#160798 (review).
flutter/packages@eb73582...07ae98c 2025-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.json:json from 20240303 to 20241224 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#8371) 2025-01-05 [email protected] [google_maps_flutter] Activate leak testing (flutter/packages#8368) 2025-01-05 [email protected] [flutter_markdown] Fix some memory leaks and activate leak testing [prod-leak-fix] (flutter/packages#8367) 2025-01-03 [email protected] [image_picker] Removes use of PHAsset on IOS 14+ (flutter/packages#8190) 2025-01-03 [email protected] Delete unused templates `skeleton` and `app_shared` and release as `5.0.0`. (flutter/packages#8360) 2025-01-02 [email protected] [tool] Ensure that leak_tracker_flutter_testing is dev-only (flutter/packages#8365) 2025-01-02 [email protected] [pigeon] Discuss stability in README (flutter/packages#8366) 2025-01-02 [email protected] [shared_preferences] Add information about shared preferences android to docs (flutter/packages#8296) 2024-12-30 [email protected] [camera] Remove OCMock from permission tests (flutter/packages#8350) 2024-12-29 [email protected] Drop vector bits from allowed_unpinned_deps.yaml (flutter/packages#8327) 2024-12-28 [email protected] [camera] Fix memory leaks in example and activate leak testing (flutter/packages#8287) 2024-12-27 [email protected] [pigeon] Adds platform for imports that aren't support on a platform (flutter/packages#8338) 2024-12-26 [email protected] Bump Plugin Example Apps to TargetSdkVersion >= 34 (flutter/packages#8285) 2024-12-26 [email protected] Re-create `templates/app`, add deprecation notices for `app_shared` and `skeleton`. (flutter/packages#8336) 2024-12-26 [email protected] Update Gradle Command Test to Only Accept Gradle Declarative Apply (flutter/packages#8325) 2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.3.1-android to 33.4.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#8331) 2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.3.4 to 1.4.1 in /packages/camera/camera_android_camerax/android (flutter/packages#8330) 2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump com.google.truth:truth, com.google.code.gson:gson, com.squareup.okhttp3:okhttp in /packages/espresso/android (flutter/packages#8089) 2024-12-24 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.9.2 to 1.9.3 in /packages/image_picker/image_picker_android/android (flutter/packages#7897) 2024-12-23 [email protected] [ci] Cumulative fixes to reopen the tree. (flutter/packages#8344) 2024-12-18 [email protected] Group dependabot updates for some gradle dependencies (flutter/packages#8100) 2024-12-18 [email protected] Applied Gradle Plugins Declaratively All Remaining Example Apps (flutter/packages#8312) 2024-12-18 49699333+dependabot[bot]@users.noreply.github.com [lifecycle]: Bump androidx.annotation:annotation from 1.7.0 to 1.9.1 in /packages/flutter_plugin_android_lifecycle/android (flutter/packages#7974) 2024-12-18 [email protected] [ci] Re-enable macOS sandboxing (flutter/packages#8293) 2024-12-18 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.android.tools.build:gradle from 7.4.1 to 8.7.2 in /packages/espresso/android (flutter/packages#8013) 2024-12-18 [email protected] [shared_preferences] Increase minimum android endorsed version (flutter/packages#8318) 2024-12-17 [email protected] Revert "[shared_preferences] Add shared preferences devtools" (flutter/packages#8314) 2024-12-16 [email protected] [shared_preferences] Add shared preferences devtools (flutter/packages#6749) 2024-12-16 [email protected] [google_adsense] Add optional init parameters. (flutter/packages#8297) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ter#161101) - update the engine and flutter_tools to be forward compatible with the upcoming shelf_web_socket v3.0 *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* - dart-lang/shelf#457 - dart-lang/shelf#463 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Closes flutter#160692. All references of `skeleton` and `app_shared` have been completely removed, including in `flutter_template_images`. See flutter/packages#8360.
…lutter#161140) Ensures that the onscreen command buffer is blocked via the render ready semaphore, instead of just the layout transition. I can confirm this fixes the rendering artifacts on the Samsung a50 - which I suspect are the same as the issues these other devices are having. Essentially, without the semaphore protecting the onscreen pass we can end up writing to the color attachment while it is still being read. * flutter#160522 * flutter#160370
Update reviewer. I didn't know this existed until I saw flutter#161001. Introduced flutter#140363. Tested credentials are used in the cherry-pick bot: https://github.com/flutter/flutter/blob/3762f2e9731ce97808fb2d78805f6712be83654d/.github/workflows/easy-cp.yml#L69
`firebase_release_smoke_test` was [marked flaky](flutter#147338) due to a firebase outage in April. `firebase_android_embedding_v2_smoke_test` was deleted with flutter#158223. `firebase_abstract_method_smoke_test` was deleted with flutter#159145 Closes flutter#147335.
…gup (flutter#160993) This should have been marked unflaky when flutter#124636 was fixed with flutter#127128. However it wasn't, and is now failing on a legit behavior change the test caught. The test is now failing due to flutter#153594, and if this test hadn't been marked flaky the commit in question would closed the tree and been reverted.
This should have been marked unflaky when flutter#156943 was closed.
Closes flutter#154143. The entire engine sub-repo is now checked for Dart analysis issues, so a separate command is not needed.
Verifying the framework golden workflow Part of resolving flutter#160556 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
fixes flutter#160806 - The error message will never say success anymore. - The error clause is slightly more permissive. If this resolves the issue though, the driver for the emulator has a bug in it since it shouldn't return `success` and zero configs. It's probably just indicating that it successfully found zero apropos configs. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…efactors to do so (flutter#160984) Closes flutter#160218. Basically, replaces `String?` with `sealed class TestCompilerResult {}`, and ensures `errorMessage` is propogated. We'll be using this path now for _all_ integration tests (not just for web-specific things), so I'd like to get error messages.
…U bug (flutter#161192) Generating the final 1x1 mip level of a texture causes the entire texture to become corrupted on some Adreno GPUs. flutter#160441 flutter#159876 flutter#160587
…er#165057) Update dart version
…ss of Impeller state. (flutter#165090) CP of flutter#165075 > There are currently a large amount of crashes coming from older devices that we don't have good test coverage for. For now, lets remove the fallback to ImpellerGLES on old devices and instead use SkiaGLES, which we know from experience works on these older devices.
cherry-pick of flutter#165008 ## Impacted Users Impeller users. ## Impact Description Text that is rotated 180 degrees exactly will render as if it is scaled by {-1, 1} instead of {-1, -1}. ## Workaround You can rotate text 180.001 degrees instead but the fidelity will be less. ## Risk If it's wrong it could break all text rendering. There are golden tests for it. ## Test Coverage Golden tests (which are not run on release branches) ## Validation Steps flutter#164958 has reproduction code
Cherry pick fix of flutter#164606 .
Changelog for flutter#165075, the dart stable change and for flutter#165080
…er#165139) Only the engine version change.
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * flutter#164935 * flutter#165620 * flutter#165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
flutter#165428) ## Impacted Users Impeller, all platforms ## Impact Description Text that is scaled over 48x will render at the incorrect size and position ## Workaround Change the font size instead of using a scale, but this isn't always clear from the framework usage. ## Risk If it is wrong, text will be rendered incorrectly. ## Test Coverage A golden test was written but they aren't automatically executed on release branches. ## Validation Steps flutter#165130 has reproduction code
Similar to flutter#166438 Fixes flutter#66553 Cherry pick the following prs to hopefully fix pre/post submits against 3.29. * flutter#165692 * flutter#165675 * flutter#165678 * flutter#166559 * Does not include flutter#165818
… mips. (flutter#165430) cherry-pick of flutter#165098 ## Impacted Users Impeller users developing on the Android Emulator (or some old hardware) ## Impact Description Crash in the Flutter app ## Workaround (Is there a workaround for this issue?) Use a real android device. ## Risk (What is the risk level of this cherry-pick?) ## Test Coverage (Are you confident that your fix is well-tested by automated tests?) Yes, there is an integration test that captures most of the problem. ## Validation Steps (What are the steps to validate that this fix works?) flutter#163421 has reproduction steps
…er#166789) Impacted Users: Flutter Release team, no external users impacted Impact Description: Runs tests on Xcode 16 and iOS 18 Simulator Workaround: N/A Risk: Low Test Coverage: Yes Validation Steps: N/A
…ocalizations (flutter#166337) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? flutter#163627 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples [flutter/163627](flutter#163627): Fix issue where placeholder types in ARB localizations weren't used for type inference, causing a possible type mismatch with the placeholder field defined in the template. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Developers are unable to successfully generate localization code without making changes across all of their ARB files. ### Workaround: Is there a workaround for this issue? Downgrade to 3.27 or explicitly define types for all impacted placeholders across all template and localization files. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? See https://github.com/benthillerkus/i18n_repro
…r#166772) Cherry picks flutter#165818 `update_engine_version.{ps1|sh}` needs to operate on a foreign repository. When flutter is run in a git-hook, these environment variables will override our git calls location and corrupt the install. Cherry pick notes: The files are diverging a bit; but the guts of the change were clean (ps1|sh) and the tests just needed some care.
…on in UI isolates on hot restart (flutter#166064) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: flutter#161466 ### Changelog Description: [flutter/161466](flutter#161466): Fixed issue where hot restart could hang indefinitely if "Pause on Unhandled Exceptions" was enabled and a call to `Isolate.run` had not completed. ### Impact Description: Hot restart (and the Dart-Code extension) could end up in a bad state where hot restart never completes and interacting with the application via the Dart-Code extension doesn't work as expected. The application becomes unresponsive and must be fully restarted to continue development. `Isolate.run` is used to load license files in the background, meaning that users don't need to explicitly be spawning isolates to encounter this issue. ### Workaround: Is there a workaround for this issue? Explicitly disable "Pause on Unhandled Exceptions", which is typically enabled by default. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? 1. Create a Flutter project with the following `main.dart`: ```dart import 'dart:async'; import 'dart:developer'; import 'dart:isolate'; import 'package:flutter/material.dart'; void main() { WidgetsFlutterBinding.ensureInitialized().platformDispatcher.onError = (Object error, StackTrace? stack) { return true; }; runApp( const Center( child: Text( 'Hello, world!', key: Key('title'), textDirection: TextDirection.ltr, ), ), ); Isolate.run(() { print('COMPUTING'); debugger(); }); } ``` 2. Run the application in debug mode and perform a hot restart once `COMPUTING` appears on `stdout`. Hot restart should complete successfully.
Also cleaned up the code we use to create this zip file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.