Skip to content

fix: shorebird android tests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felangel merged 2 commits into from
Feb 27, 2025
Merged

fix: shorebird android tests #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaaec81
fix: shorebird android tests
felangel Feb 27, 2025
5acc6c8
disable windows
felangel Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions packages/shorebird_tests/test/shorebird_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,23 @@ extension ShorebirdProjectDirectoryOnDirectory on Directory {
path.join(this.path, 'android', 'app', 'build.gradle'),
);

Future<void> addPubDependency(String name, {bool dev = false}) {
return _runFlutterCommand(
Future<void> addPubDependency(String name, {bool dev = false}) async {
final result = await _runFlutterCommand(
['pub', 'add', if (dev) '--dev', name],
workingDirectory: this,
);
if (result.exitCode != 0) {
throw Exception(
'Failed to run `flutter pub add $name`: ${result.stderr}');
}
}

Future<void> addProjectFlavors() async {
await addPubDependency('flutter_flavorizr', dev: true);
await addPubDependency(
// TODO(felangel): revert to using published version once 3.29.0 support is released.
// https://github.com/AngeloAvv/flutter_flavorizr/pull/291
'dev:flutter_flavorizr:{"git":{"url":"https://github.com/wjlee611/flutter_flavorizr.git","ref":"chore/temp-migrate-3-29","path":"."}}',
);

await File(
path.join(
Expand Down Expand Up @@ -153,10 +161,14 @@ flavors:
bundleId: "com.example.shorebird_test.global"
''');

await _runFlutterCommand(
final result = await _runFlutterCommand(
['pub', 'run', 'flutter_flavorizr'],
workingDirectory: this,
);
if (result.exitCode != 0) {
throw Exception(
'Failed to run `flutter pub run flutter_flavorizr`: ${result.stderr}');
}
}

void addShorebirdFlavors() {
Expand Down