fix: public key bundling #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
force-pushed
the
fix/public-key-bundleling
branch
from
ffaf771 to
153f83c
Compare
bryanoltman
reviewed
May 22, 2024
bryanoltman
reviewed
May 22, 2024
bryanoltman
reviewed
May 22, 2024
bryanoltman
reviewed
May 22, 2024
bryanoltman
approved these changes
May 22, 2024
bryanoltman
left a comment
bryanoltman
left a comment
There was a problem hiding this comment.
Left a few minor comments, but LGTM!
Co-authored-by: Bryan Oltman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bundleling the public key in the shorebird.yaml file on android, we were not including the rest of the file, leaving the yaml incomplete.
This PR adds a fix for that.